background.js - Issue 5138680696012800: Issue 616 - Enforce $generichide and $genericblock in Chrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: background.js

Issue 5138680696012800: Issue 616 - Enforce $generichide and $genericblock in Chrome (Closed)

Patch Set: Consider $genericblock when blocking popups. Created March 12, 2015, 7:18 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: background.js

diff --git a/background.js b/background.js

index 36158a2d5c129bcb5b81a9d375a72e7b24e2358f..2034beb32525e365a5bc09f6067288c093ead08d 100644

--- a/background.js

+++ b/background.js

@@ -471,7 +471,9 @@ ext.onMessage.addListener(function (msg, sender, sendResponse)

!isFrameWhitelisted(sender.page, sender.frame, "ELEMHIDE"))

{

var noStyleRules = false;

+ var specificOnly = isFrameWhitelisted(sender.page, sender.frame, "GENERICHIDE");

var host = extractHostFromFrame(sender.frame);

for (var i = 0; i < noStyleRulesHosts.length; i++)

{

var noStyleHost = noStyleRulesHosts[i];

@@ -481,7 +483,7 @@ ext.onMessage.addListener(function (msg, sender, sendResponse)

noStyleRules = true;

}

- selectors = ElemHide.getSelectorsForDomain(host, false);

+ selectors = ElemHide.getSelectorsForDomain(host, specificOnly);

if (noStyleRules)

{

selectors = selectors.filter(function(s)

« no previous file with comments | « no previous file | popupBlocker.js » ('j') | no next file with comments »