Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: webrequest.js

Issue 5138680696012800: Issue 616 - Enforce $generichide and $genericblock in Chrome (Closed)
Patch Set: Addressed feedback. Created March 12, 2015, 8:38 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « popupBlocker.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrequest.js
diff --git a/webrequest.js b/webrequest.js
index 68999d9c16e1ef4e7dea55dec66b134ec12b13a0..2da776efcd96001ca4581c264b4ef60e967c763b 100644
--- a/webrequest.js
+++ b/webrequest.js
@@ -61,11 +61,13 @@ function onBeforeRequest(url, type, page, frame)
var docDomain = extractHostFromFrame(frame);
var key = getKey(page, frame);
+ var specificOnly = isFrameWhitelisted(page, frame, "GENERICBLOCK");
var filter = defaultMatcher.matchesAny(
stringifyURL(url),
type, docDomain,
isThirdParty(url, docDomain),
- key
+ key,
+ specificOnly
);
// We can't listen to onHeadersReceived in Safari so we need to
« no previous file with comments | « popupBlocker.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld