Issue 354 - Avoid a string copy that is unnecessary most of the time

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 294 matching lines @@
   /**
    * Map containing domains that this filter should match on/not match on or null if the filter should match on all domains
    * @type Object
    */
   get domains()
   {
     let domains = null;
 
     if (this.domainSource)
     {
-      let list = this.domainSource.split(this.domainSeparator);
+      let source = this.domainSource;
+      if (!(this instanceof RegExpFilter)) {

[Wladimir Palant, 2014/04/10 18:43:38]

I'd rather not hardcode the RegExpFilter class here. IMHO it is better to use a
property like domainSourceUppercased that is true for RegExpFilter but false for
ElemHideFilter - the same way we do it with domainSeparator property for
example.

+        // RegExpFilter already have uppercase domains
+        source = source.toUpperCase();
+      }
+      let list = source.split(this.domainSeparator);
       if (list.length == 1 && list[0][0] != "~")
       {
         // Fast track for the common one-domain scenario
         domains = {__proto__: null, "": false};
         if (this.ignoreTrailingDot)
           list[0] = list[0].replace(/\.+$/, "");
         domains[list[0]] = true;
       }
       else
       {
@@ skipping 19 matching lines @@
           }
 
           if (!domains)
             domains = {__proto__: null};
 
           domains[domain] = include;
         }
         domains[""] = !hasIncludes;
       }
 
-      delete this.domainSource;
+      this.domainSource = null;
     }
 
     this.__defineGetter__("domains", function() domains);
     return this.domains;
   },
 
   /**
    * Checks whether this filter is active on a domain.
    */
   isActiveOnDomain: function(/**String*/ docDomain) /**Boolean*/
@@ skipping 372 matching lines @@
 /**
  * Base class for element hiding filters
  * @param {String} text see Filter()
  * @param {String} domains    (optional) Host names or domains the filter should be restricted to
  * @param {String} selector   CSS selector for the HTML elements that should be hidden
  * @constructor
  * @augments ActiveFilter
  */
 function ElemHideBase(text, domains, selector)
 {
-  ActiveFilter.call(this, text, domains ? domains.toUpperCase() : null);
+  ActiveFilter.call(this, text, domains || null);
 
   if (domains)
     this.selectorDomain = domains.replace(/,~[^,]+/g, "").replace(/^~[^,]+,?/, "").toLowerCase();
   this.selector = selector;
 }
 exports.ElemHideBase = ElemHideBase;
 
 ElemHideBase.prototype =
 {
   __proto__: ActiveFilter.prototype,
@@ skipping 106 matching lines @@
 function ElemHideException(text, domains, selector)
 {
   ElemHideBase.call(this, text, domains, selector);
 }
 exports.ElemHideException = ElemHideException;
 
 ElemHideException.prototype =
 {
   __proto__: ElemHideBase.prototype
 };