Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1238)

Issue 5153282527854592: Issue 98 - Use the libadblockplus update mechanism (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Felix Dahlke
Modified:
4 years, 9 months ago
Reviewers:
René Jeschke
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 98 - Use the libadblockplus update mechanism

Patch Set 1 : #

Total comments: 16

Patch Set 2 : Reduce scope of UPDATE_NOTIFICATION_ID and move network error logging to AndroidUpdateCheckDoneCall… #

Total comments: 2

Patch Set 3 : Store logging tag in a constant #

Patch Set 4 : Only append the revision to the version for devbuilds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -333 lines) Patch
M AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
M jni/Android.mk View 1 chunk +4 lines, -3 lines 0 comments Download
M jni/JniCallbacks.h View 1 chunk +7 lines, -0 lines 0 comments Download
M jni/JniFilterEngine.cpp View 2 chunks +31 lines, -0 lines 0 comments Download
A jni/JniUpdateAvailableCallback.cpp View 1 chunk +68 lines, -0 lines 0 comments Download
M res/menu/menu_preferences.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M res/values/strings.xml View 1 chunk +1 line, -0 lines 0 comments Download
M src/org/adblockplus/android/ABPEngine.java View 1 2 3 7 chunks +11 lines, -10 lines 0 comments Download
M src/org/adblockplus/android/AdblockPlus.java View 4 chunks +0 lines, -47 lines 0 comments Download
M src/org/adblockplus/android/AndroidUpdateAvailableCallback.java View 2 chunks +4 lines, -16 lines 0 comments Download
M src/org/adblockplus/android/AndroidUpdateCheckDoneCallback.java View 1 2 2 chunks +7 lines, -19 lines 0 comments Download
M src/org/adblockplus/android/Preferences.java View 1 chunk +3 lines, -0 lines 0 comments Download
M src/org/adblockplus/android/Utils.java View 1 2 chunks +17 lines, -14 lines 0 comments Download
R src/org/adblockplus/android/updater/AlarmReceiver.java View 1 chunk +0 lines, -223 lines 0 comments Download
M src/org/adblockplus/libadblockplus/FilterEngine.java View 2 chunks +14 lines, -0 lines 0 comments Download
A src/org/adblockplus/libadblockplus/UpdateAvailableCallback.java View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 16
Felix Dahlke
Here goes. Please keep an eye out for dead code I forgot to remove, and ...
4 years, 9 months ago (2014-09-25 16:01:12 UTC) #1
René Jeschke
On 2014/09/25 16:01:12, Felix H. Dahlke wrote: > Here goes. Please keep an eye out ...
4 years, 9 months ago (2014-09-26 10:14:58 UTC) #2
René Jeschke
http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/res/values/strings.xml File res/values/strings.xml (right): http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/res/values/strings.xml#newcode93 res/values/strings.xml:93: <string name="menu_update">Check for updates</string> Don't forget: We need localizations ...
4 years, 9 months ago (2014-09-26 10:24:05 UTC) #3
Felix Dahlke
On 2014/09/26 10:14:58, René Jeschke wrote: > We can remove these JNI bindings if we ...
4 years, 9 months ago (2014-09-26 11:20:24 UTC) #4
René Jeschke
http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java File src/org/adblockplus/android/Utils.java (right): http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java#newcode35 src/org/adblockplus/android/Utils.java:35: private static final int UPDATE_NOTIFICATION_ID = R.string.app_name + 1; ...
4 years, 9 months ago (2014-09-26 11:31:50 UTC) #5
Felix Dahlke
http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java File src/org/adblockplus/android/Utils.java (right): http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java#newcode35 src/org/adblockplus/android/Utils.java:35: private static final int UPDATE_NOTIFICATION_ID = R.string.app_name + 1; ...
4 years, 9 months ago (2014-09-26 11:39:05 UTC) #6
René Jeschke
http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java File src/org/adblockplus/android/Utils.java (right): http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java#newcode35 src/org/adblockplus/android/Utils.java:35: private static final int UPDATE_NOTIFICATION_ID = R.string.app_name + 1; ...
4 years, 9 months ago (2014-09-26 11:59:17 UTC) #7
Felix Dahlke
New patch set up. http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java File src/org/adblockplus/android/Utils.java (right): http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java#newcode35 src/org/adblockplus/android/Utils.java:35: private static final int UPDATE_NOTIFICATION_ID ...
4 years, 9 months ago (2014-09-26 13:05:13 UTC) #8
René Jeschke
http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java File src/org/adblockplus/android/Utils.java (right): http://codereview.adblockplus.org/5153282527854592/diff/5668600916475904/src/org/adblockplus/android/Utils.java#newcode35 src/org/adblockplus/android/Utils.java:35: private static final int UPDATE_NOTIFICATION_ID = R.string.app_name + 1; ...
4 years, 9 months ago (2014-09-26 13:10:51 UTC) #9
Felix Dahlke
http://codereview.adblockplus.org/5153282527854592/diff/5693417237512192/src/org/adblockplus/android/AndroidUpdateCheckDoneCallback.java File src/org/adblockplus/android/AndroidUpdateCheckDoneCallback.java (right): http://codereview.adblockplus.org/5153282527854592/diff/5693417237512192/src/org/adblockplus/android/AndroidUpdateCheckDoneCallback.java#newcode40 src/org/adblockplus/android/AndroidUpdateCheckDoneCallback.java:40: Log.e(Utils.getTag(AndroidUpdateCheckDoneCallback.class), "Update check failed: " + error); On 2014/09/26 ...
4 years, 9 months ago (2014-09-26 13:15:31 UTC) #10
René Jeschke
LGTM We need two follow up issues: 1. Update check notification for manual update 2. ...
4 years, 9 months ago (2014-09-26 13:19:46 UTC) #11
Felix Dahlke
On 2014/09/26 13:19:46, René Jeschke wrote: > LGTM > > > We need two follow ...
4 years, 9 months ago (2014-09-26 13:31:22 UTC) #12
René Jeschke
On 2014/09/26 13:31:22, Felix H. Dahlke wrote: > On 2014/09/26 13:19:46, René Jeschke wrote: > ...
4 years, 9 months ago (2014-09-26 13:32:33 UTC) #13
Felix Dahlke
On 2014/09/26 13:32:33, René Jeschke wrote: > On 2014/09/26 13:31:22, Felix H. Dahlke wrote: > ...
4 years, 9 months ago (2014-09-26 13:38:19 UTC) #14
Felix Dahlke
Uploaded another patch set - had to make sure we don't append the revision number ...
4 years, 9 months ago (2014-09-26 15:09:33 UTC) #15
René Jeschke
4 years, 9 months ago (2014-09-26 15:19:05 UTC) #16
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5