Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 5163192602853376: Issue 364 - Extension manifest changes necessary to upload devbuilds (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by Wladimir Palant
Modified:
5 years, 6 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 364 - Extension manifest changes necessary to upload devbuilds

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M manifest.json.tmpl View 1 chunk +7 lines, -2 lines 2 comments Download

Messages

Total messages: 3
Wladimir Palant
5 years, 6 months ago (2014-04-25 08:14:35 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5163192602853376/diff/5629499534213120/manifest.json.tmpl File manifest.json.tmpl (left): http://codereview.adblockplus.org/5163192602853376/diff/5629499534213120/manifest.json.tmpl#oldcode20 manifest.json.tmpl:20: "name": "__MSG_name__{% if experimentalAPI %} experimental build{% endif %}", ...
5 years, 6 months ago (2014-04-25 09:19:01 UTC) #2
Wladimir Palant
5 years, 6 months ago (2014-04-25 09:46:52 UTC) #3
http://codereview.adblockplus.org/5163192602853376/diff/5629499534213120/mani...
File manifest.json.tmpl (left):

http://codereview.adblockplus.org/5163192602853376/diff/5629499534213120/mani...
manifest.json.tmpl:20: "name": "__MSG_name__{% if experimentalAPI %}
experimental build{% endif %}",
On 2014/04/25 09:19:01, Sebastian Noack wrote:
> LGTM, assuming that the "experimental build" is deprecated.

It is, we no longer link to the experimental builds. We merely didn't come
around merging them into the regular builds yet - something we will have to do
now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5