src/plugin/PluginFilter.h - Issue 5163396739629056: Issue #1234 - Remove CString from ShouldBlock(), IsElementHidden() declarations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/plugin/PluginFilter.h

Issue 5163396739629056: Issue #1234 - Remove CString from ShouldBlock(), IsElementHidden() declarations (Closed)

Patch Set: Created Aug. 7, 2014, 2:20 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 #ifndef _PLUGIN_FILTER_H_	1 #ifndef _PLUGIN_FILTER_H_

2 #define _PLUGIN_FILTER_H_	2 #define _PLUGIN_FILTER_H_

3	3

4	4

5 #include "PluginTypedef.h"	5 #include "PluginTypedef.h"

6 #include <memory>	6 #include <memory>

7	7

8 enum CFilterElementHideAttrPos	8 enum CFilterElementHideAttrPos

9 {	9 {

10 POS_NONE = 0, STARTING, ENDING, ANYWHERE, EXACT	10 POS_NONE = 0, STARTING, ENDING, ANYWHERE, EXACT

(...skipping 144 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
155	155

156 public:	156 public:

157	157

158 CPluginFilter(const CString& dataPath = "");	158 CPluginFilter(const CString& dataPath = "");

159	159

160 bool LoadHideFilters(std::vector<std::wstring> filters);	160 bool LoadHideFilters(std::vector<std::wstring> filters);

161	161

162 bool AddFilterElementHide(CString filter);	162 bool AddFilterElementHide(CString filter);

163	163

164	164

165 bool IsElementHidden(const CString& tag, IHTMLElement* pEl, const CString& dom ain, const CString& indent) const;	165 bool IsElementHidden(const std::wstring& tag, IHTMLElement* pEl, const std::ws tring& domain, const std::wstring& indent) const;

166	166

167	167

168 bool ShouldBlock(CString src, int contentType, const CString& domain, bool add Debug=false) const;	168 bool ShouldBlock(const std::wstring& src, int contentType, const std::wstring& domain, bool addDebug=false) const;

169	169

170 HANDLE hideFiltersLoadedEvent;	170 HANDLE hideFiltersLoadedEvent;

171 };	171 };

172	172

173	173

174 #endif // _PLUGIN_FILTER_H_	174 #endif // _PLUGIN_FILTER_H_

OLD	NEW