 Issue 5163396739629056:
  Issue #1234 - Remove CString from ShouldBlock(), IsElementHidden() declarations  (Closed)
    
  
    Issue 5163396739629056:
  Issue #1234 - Remove CString from ShouldBlock(), IsElementHidden() declarations  (Closed) 
  | Index: src/plugin/AdblockPlusClient.h | 
| =================================================================== | 
| --- a/src/plugin/AdblockPlusClient.h | 
| +++ b/src/plugin/AdblockPlusClient.h | 
| @@ -28,7 +28,7 @@ | 
| CComAutoCriticalSection m_criticalSectionFilter; | 
| CComAutoCriticalSection m_criticalSectionCache; | 
| - std::map<CString,bool> m_cacheBlockedSources; | 
| + std::map<std::wstring,bool> m_cacheBlockedSources; | 
| 
Felix Dahlke
2014/09/30 13:30:15
Good time as any to add a space after the comma he
 
Eric
2014/09/30 17:56:40
Done.
 | 
| std::shared_ptr<Communication::Pipe> enginePipe; | 
| CriticalSection enginePipeLock; | 
| @@ -49,9 +49,9 @@ | 
| // Removes the url from the list of whitelisted urls if present | 
| // Only called from ui thread | 
| - bool ShouldBlock(CString src, int contentType, const CString& domain, bool addDebug=false); | 
| + bool ShouldBlock(const std::wstring& src, int contentType, const std::wstring& domain, bool addDebug=false); | 
| - bool IsElementHidden(const CString& tag, IHTMLElement* pEl, const CString& domain, const CString& indent, CPluginFilter* filter); | 
| + bool IsElementHidden(const std::wstring& tag, IHTMLElement* pEl, const std::wstring& domain, const std::wstring& indent, CPluginFilter* filter); | 
| bool IsWhitelistedUrl(const std::wstring& url); | 
| int GetIEVersion(); |