Issue 1283 - wrong usage of memset, fix sizeof, make proper initializing

src/plugin/PluginSettings.cpp

 #include "PluginStdAfx.h"
 
 #include <Wbemidl.h>
 #include <time.h>
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginMutex.h"
 #include "../shared/Utils.h"
@@ skipping 213 matching lines @@
     ReadWhitelist(true);
   }
 
   return true;
 }
 
 DWORD CPluginSettings::GetWindowsBuildNumber()
 {
   if (m_WindowsBuildNumber == 0)
   {
-    OSVERSIONINFOEX osvi;
-    SYSTEM_INFO si;
-    BOOL bOsVersionInfoEx;
-
-    ZeroMemory(&si, sizeof(SYSTEM_INFO));
-    ZeroMemory(&osvi, sizeof(OSVERSIONINFOEX));
-
-    osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
-    bOsVersionInfoEx = GetVersionEx((OSVERSIONINFO*) &osvi);
-
-    m_WindowsBuildNumber = osvi.dwBuildNumber;
+    OSVERSIONINFOEX osvi = {};
+    osvi.dwOSVersionInfoSize = sizeof(osvi);
+    if (GetVersionExW(reinterpret_cast<OSVERSIONINFO*>(&osvi)) != 0)
+    {
+      m_WindowsBuildNumber = osvi.dwBuildNumber;
+    }
   }
 
   return m_WindowsBuildNumber;
 }
 
 void CPluginSettings::SetSubscription(const std::wstring& url)
 {
   CPluginClient::GetInstance()->SetSubscription(url);
   RefreshWhitelist();
 }
@@ skipping 15 matching lines @@
 
 CString CPluginSettings::GetAppLocale()
 {
   return to_CString(GetBrowserLanguage());
 }
 
 CString CPluginSettings::GetDocumentationLink()
 {
   return CString(CPluginClient::GetInstance()->GetDocumentationLink().c_str());
 }