Issue 1283 - wrong usage of memset, fix sizeof, make proper initializing

src/shared/Communication.cpp

 #include <Windows.h>
 #include <Lmcons.h>
 #include <Sddl.h>
 #include <aclapi.h>
 #include <strsafe.h>
 
 #include "AutoHandle.h"
 #include "Communication.h"
 #include "Utils.h"
 
@@ skipping 193 matching lines @@
   }
   free(securityDescriptor);
 }
 
 Communication::Pipe::Pipe(const std::wstring& pipeName, Communication::Pipe::Mode mode)
 {
   pipe = INVALID_HANDLE_VALUE;
   if (mode == MODE_CREATE)
   {
     SECURITY_ATTRIBUTES securityAttributes = {};
-    securityAttributes.nLength = sizeof(SECURITY_ATTRIBUTES);
+    securityAttributes.nLength = sizeof(securityAttributes);
     securityAttributes.bInheritHandle = TRUE;
 
     std::tr1::shared_ptr<SECURITY_DESCRIPTOR> sharedSecurityDescriptor; // Just to simplify cleanup
     AutoHandle token;
     OpenProcessToken(GetCurrentProcess(), TOKEN_READ, token);
     
     if (IsWindowsVistaOrLater())
     {
       std::auto_ptr<SID> logonSid = GetLogonSid(token);
       // Create a SECURITY_DESCRIPTOR that has both Low Integrity and allows access to all AppContainers
@@ skipping 33 matching lines @@
 }
 
 Communication::Pipe::~Pipe()
 {
   CloseHandle(pipe);
 }
 
 Communication::InputBuffer Communication::Pipe::ReadMessage()
 {
   std::stringstream stream;
-  std::auto_ptr<char> buffer(new char[bufferSize]);
+  std::unique_ptr<char[]> buffer(new char[bufferSize]);
   bool doneReading = false;
   while (!doneReading)
   {
     DWORD bytesRead;
     if (ReadFile(pipe, buffer.get(), bufferSize * sizeof(char), &bytesRead, 0))
       doneReading = true;
     else
     {
       DWORD lastError = GetLastError();
       switch (lastError)
@@ skipping 13 matching lines @@
   return Communication::InputBuffer(stream.str());
 }
 
 void Communication::Pipe::WriteMessage(Communication::OutputBuffer& message)
 {
   DWORD bytesWritten;
   std::string data = message.Get();
   if (!WriteFile(pipe, data.c_str(), static_cast<DWORD>(data.length()), &bytesWritten, 0))
     throw std::runtime_error("Failed to write to pipe");
 }