Issue 1283 - wrong usage of memset, fix sizeof, make proper initializing

src/plugin/PluginSystem.cpp

 #include "PluginStdAfx.h"
 #include "PluginSystem.h"
 #include "PluginClient.h"
 #include <array>
 
 std::wstring GetBrowserLanguage()
 {
   LANGID lcid = GetUserDefaultLangID();
   std::wstring lang;
   // According to http://msdn.microsoft.com/en-us/library/windows/desktop/dd373848(v=vs.85).aspx
   // The maximum number of characters allowed for this string is nine, including a terminating null character.
   {
     std::array<wchar_t, 9> localeLanguage;

[Eric, 2014/10/09 13:49:57]

I think that page means that you have nine characters for the locale and one
terminating null. I say I think because the wording isn't totally clear. I'd use
an array length of 10 to be safe.

-    localeLanguage.fill(L'\0');
     int res = GetLocaleInfoW(lcid, LOCALE_SISO639LANGNAME, localeLanguage.data(), localeLanguage.size());

[Oleksandr, 2014/10/17 07:09:07]

We could use std::wstring for localeLanguage here as well

     if (res == 0)
     {
       DEBUG_ERROR_LOG(::GetLastError(), PLUGIN_ERROR_SYSINFO, PLUGIN_ERROR_SYSINFO_BROWSER_LANGUAGE, "System::GetBrowserLang - Failed");
     }
     else
     {
       lang += localeLanguage.data();
     }
   }
   lang += L"-";
   {
     std::array<wchar_t, 9> localeCountry;
-    localeCountry.fill(L'\0');

[Eric, 2014/10/09 13:49:57]

Also here.

     int res = GetLocaleInfoW(lcid, LOCALE_SISO3166CTRYNAME, localeCountry.data(), localeCountry.size());
     if (res == 0)
     {
       DEBUG_ERROR_LOG(::GetLastError(), PLUGIN_ERROR_SYSINFO, PLUGIN_ERROR_SYSINFO_BROWSER_LANGUAGE, "System::GetBrowserLang - failed to retrieve country");
     }
     else
     {
       lang += localeCountry.data();
     }
   }
   return lang;
 }