Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: include/AdblockPlus/tr1_memory.h
Issue
5163715573841920
:
Issue 768 - Switch from TR1 to C++11 (Closed)
Left Patch Set:
Created July 11, 2014, 2:24 p.m.
Right Patch Set: fix including of <memory>
Created Aug. 7, 2015, 6:07 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: rebase
Patch Set 3: address comments
Patch Set 4: fix including of <memory>
Right:
Patch Set 1: None
Patch Set 2: rebase
Patch Set 3: address comments
Patch Set 4: fix including of <memory>
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Makefile
README.md
common.gypi
include/AdblockPlus/DefaultFileSystem.h
include/AdblockPlus/FileSystem.h
include/AdblockPlus/FilterEngine.h
include/AdblockPlus/JsEngine.h
include/AdblockPlus/JsValue.h
include/AdblockPlus/LogSystem.h
include/AdblockPlus/Notification.h
include/AdblockPlus/WebRequest.h
include/AdblockPlus/tr1_functional.h
include/AdblockPlus/tr1_memory.h
libadblockplus.gyp
src/DefaultFileSystem.cpp
src/FileSystemJsObject.cpp
src/FilterEngine.cpp
src/JsEngine.cpp
test/BaseJsTest.h
test/ConsoleJsObject.cpp
test/DefaultFileSystem.cpp
test/FileSystemJsObject.cpp
test/FilterEngine.cpp
test/Notification.cpp
test/Prefs.cpp
test/UpdateCheck.cpp
third_party/googletest.gyp
Left:
Side by side diff
|
Download
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« include/AdblockPlus/tr1_functional.h
('k') |
libadblockplus.gyp »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
LEFT
RIGHT
« include/AdblockPlus/tr1_functional.h
('k') |
libadblockplus.gyp »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 5163715573841920: Issue 768 - Switch from TR1 to C++11 (Closed)
Created July 11, 2014, 2:24 p.m. by Wladimir Palant
Modified Aug. 25, 2015, 2:34 p.m.
Reviewers: René Jeschke, Felix Dahlke, sergei
Base URL:
Comments: 40
This is Rietveld