Issue 1201 - Enabling/disabling ABP everywhere applies only in the next opened tab

src/plugin/Plugin.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 13 matching lines @@
 #include "../../build/ia32/AdblockPlus_i.c"
 #endif
 
 #include "PluginClass.h"
 #include "PluginClient.h"
 #include "PluginSystem.h"
 #include "PluginSettings.h"
 #include "PluginMimeFilterClient.h"
 #include "Msiquery.h"
 #include "PluginFilter.h"
+#include "PluginClientFactory.h"
 
 #include "../shared/Dictionary.h"
 
 CComModule _Module;
 
 BEGIN_OBJECT_MAP(ObjectMap)
   OBJECT_ENTRY(CLSID_PluginClass, CPluginClass)
 END_OBJECT_MAP()
 
 //Dll Entry Point
@@ skipping 27 matching lines @@
     break;
   }
 
   return TRUE;
 }
 
 
 STDAPI DllCanUnloadNow(void)
 {
   LONG count = _Module.GetLockCount();
   if (_Module.GetLockCount() == 0)

[Eric, 2015/03/27 13:35:50]

If I've read the ATL code right, this condition means that we have no
outstanding instance produced from ATL-derived factories.

   {
     if (CPluginSettings::s_instance != NULL)
     {
       delete CPluginSettings::s_instance;
     }
 
-    if (CPluginClass::s_mimeFilter != NULL)
-    {
-      CPluginClass::s_mimeFilter->Unregister();
-      CPluginClass::s_mimeFilter = NULL;
-    }
-
+    CPluginClientFactory::ReleaseMimeFilterClientInstance();

[Eric, 2015/03/27 13:35:50]

I've seen a crash recently during shutdown when 's_mimeFilter' was being
referenced after COM had already destroyed the instance. I'm guessing that any
reference to COM objects here is defective. That includes a reference to
's_mimeFilterInstance' through 'ReleaseMimeFilterClientInstance'. The problem is
that even though 's_mimeFilterInstance' is not 'nullptr', its value has been
invalidated by COM.

We need to manage the life cycle of the mime-filter correctly, but I don't think
this is the way to do it.

+ 
     _CrtDumpMemoryLeaks();
   }
   return (_Module.GetLockCount() == 0) ? S_OK : S_FALSE;
 }
 
 STDAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID* ppv)
 {
   return _Module.GetClassObject(rclsid, riid, ppv);
 }
 
@@ skipping 38 matching lines @@
 EXTERN_C void STDAPICALLTYPE OnInstall(MSIHANDLE hInstall, MSIHANDLE tmp)
 {
   InitPlugin(true);
 }
 
 // Called from updater
 EXTERN_C void STDAPICALLTYPE OnUpdate(void)
 {
   InitPlugin(false);
 }