Issue #41 - Bring method of determining IE version up to date

src/plugin/PluginClass.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginClass.h"
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #ifdef SUPPORT_FILTER
 #include "PluginFilter.h"
 #endif
 #include "PluginMimeFilterClient.h"
 #include "PluginClient.h"
@@ skipping 649 matching lines @@
   case DISPID_BEFORENAVIGATE:
     DEBUG_NAVI("Navi::BeforeNavigate")
       return VARIANT_TRUE;
   case DISPID_COMMANDSTATECHANGE:
     if (m_hPaneWnd == NULL)
     {
       CreateStatusBarPane();
     }
     else
     {
-      if (CPluginClient::GetInstance()->GetIEVersion() > 6)

[Oleksandr, 2014/06/22 21:53:17]

IIRC IE6 was not starting at all if these checks weren't in place. Are you
removing IE6 check here just because we no longer support it? I don't see any
point in removing the support if we already have it. Maybe we shouldn't work on
any new issues, but why remove this?

[Eric, 2014/06/25 18:52:02]

Exactly.

You and I spoke about this, and it became clear that we ought to land a number
of changes simultaneously to do this right, so I'll leave in the version changes
for now.

+      RECT rect;
+      BOOL rectRes = GetClientRect(m_hStatusBarWnd, &rect);
+      if (rectRes == TRUE)
       {
-        RECT rect;
-        BOOL rectRes = GetClientRect(m_hStatusBarWnd, &rect);
-        if (rectRes == TRUE)
-        {
-          MoveWindow(m_hPaneWnd, rect.right - 200, 0, m_nPaneWidth, rect.bottom - rect.top, TRUE);
-        }
-      }      
+        MoveWindow(m_hPaneWnd, rect.right - 200, 0, m_nPaneWidth, rect.bottom - rect.top, TRUE);
+      }
     }
     break;
   case DISPID_STATUSTEXTCHANGE:
     break;
 
   case DISPID_BEFORENAVIGATE2:
     BeforeNavigate2(pDispParams);
     break;
 
   case DISPID_DOWNLOADBEGIN:
@@ skipping 127 matching lines @@
     }
     s_criticalSectionLocal.Unlock();
 
     if (!GetAtomPaneClass())
     {
       DEBUG_ERROR_LOG(::GetLastError(), PLUGIN_ERROR_UI, PLUGIN_ERROR_UI_REGISTER_PANE_CLASS, L"Class::InitObject - RegisterClassEx");
       return false;
     }
   }
 
-
-  int ieVersion = CPluginClient::GetInstance()->GetIEVersion();
   // Create status pane
-  if (bBHO && ieVersion > 6 && !CreateStatusBarPane())
+  if (bBHO && !CreateStatusBarPane())
   {
     return false;
   }
   
   if (CPluginClient::GetInstance()->IsFirstRun())
   {   
-    // IE6 can't be accessed from another thread, execute in current thread
-    if (ieVersion < 7)
-    {
-      FirstRunThread();
-    }
-    else
-    {
-      CreateThread(NULL, NULL, (LPTHREAD_START_ROUTINE)CPluginClass::FirstRunThread, NULL, NULL, NULL);
-    }
+    CreateThread(NULL, NULL, (LPTHREAD_START_ROUTINE)CPluginClass::FirstRunThread, NULL, NULL, NULL);
     if ((m_hPaneWnd == NULL) || (!IsStatusBarEnabled()))
     {
       ShowStatusBar();
     }
 
   }
   return true;
 }
 
 bool CPluginClass::CreateStatusBarPane()
@@ skipping 1101 matching lines @@
         }
       }
     }
 
     hTabWnd = ::GetWindow(hTabWnd, GW_HWNDNEXT);
   }
 
   return hTabWnd;
 
 }