Issue #41 - Bring method of determining IE version up to date

src/plugin/PluginUserSettings.cpp

 #include "PluginStdAfx.h"
 #include "PluginUserSettings.h"
 #include <algorithm>
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "../shared/Dictionary.h"
 
 static const CString s_GetMessage = L"GetMessage";
 static const CString s_GetLanguageCount = L"GetLanguageCount";
 static const CString s_GetLanguageByIndex = L"GetLanguageByIndex";
@@ skipping 120 matching lines @@
     return DISP_E_BADINDEX;
 
   const CString& method = s_Methods[dispidMember];
 
   if (s_GetMessage == method)
   {
     if (2 != pDispparams->cArgs)
       return DISP_E_BADPARAMCOUNT;
 
     if (VT_BSTR != pDispparams->rgvarg[0].vt)
       return DISP_E_TYPEMISMATCH;

[Eric, 2014/07/29 14:49:40]

This is a fix for an unrelated defect that slipped into this patch set. Oops.

+    if (VT_BSTR != pDispparams->rgvarg[1].vt)
+      return DISP_E_TYPEMISMATCH;
 
     if (pVarResult)
     {
       CComBSTR key = pDispparams->rgvarg[0].bstrVal;
       CComBSTR section = pDispparams->rgvarg[1].bstrVal;
       CStringW message = sGetMessage((BSTR)section, (BSTR)key);
 
       pVarResult->vt = VT_BSTR;
       pVarResult->bstrVal = SysAllocString(message);
     }
@@ skipping 200 matching lines @@
       CPluginClient* client = CPluginClient::GetInstance();
       client->RemoveSubscription(client->GetPref(L"subscriptions_exceptionsurl", L""));
     }
   }
   else
     return DISP_E_MEMBERNOTFOUND;
 
   return S_OK;
 }