src/shared/IE_version.h - Issue 5171515343503360: Issue #41 - Bring method of determining IE version up to date

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/shared/IE_version.h

Issue 5171515343503360: Issue #41 - Bring method of determining IE version up to date (Closed)

Left Patch Set: Created July 23, 2014, 4:55 p.m.

Right Patch Set: Final (?) 2 Created Jan. 5, 2015, 1:02 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
	1 #ifndef IE_VERSION_H

	2 #define IE_VERSION_H

	3

1 #include <string>	4 #include <string>

2	5

3 namespace AdblockPlus	6 namespace AdblockPlus

4 {	7 {

5 namespace IE	8 namespace IE
Oleksandr 2014/07/25 22:23:46 I don't think we actually need any of these namesp I don't think we actually need any of these namespaces. Eric 2014/07/26 15:54:46 1) I'm in favor of using AdblockPlus for the names Show quoted text On 2014/07/25 22:23:46, Oleksandr wrote: > I don't think we actually need any of these namespaces. 1) I'm in favor of using AdblockPlus for the namespace for library code. The registry and IE version facilities are definitely in that category. 2) The 'IE' namespace is what I plan on using for all IE support. As of this moment it's only these two functions. I also intend to use it for all the IE wrapper classes. And it will definitely be a good idea to have a namespace for those, because there are lots of generic words there that we should preemptively disambiguate. These wrapper classes are not merely cosmetic. I'm fairly sure that we can fix #264 (ABP attributes are added to every element in contentEditable elements) with some COM tricks and a wrapper class around IHTMLElement. Oleksandr 2014/07/27 22:13:30 It does make sense. We might start doing that. @se It does make sense. We might start doing that. @sergei, would you agree on the naming? On 2014/07/26 15:54:46, Eric wrote: Show quoted text > On 2014/07/25 22:23:46, Oleksandr wrote: > > I don't think we actually need any of these namespaces. > > 1) I'm in favor of using AdblockPlus for the namespace for library code. The > registry and IE version facilities are definitely in that category. > > 2) The 'IE' namespace is what I plan on using for all IE support. As of this > moment it's only these two functions. I also intend to use it for all the IE > wrapper classes. And it will definitely be a good idea to have a namespace for > those, because there are lots of generic words there that we should preemptively > disambiguate. > > These wrapper classes are not merely cosmetic. I'm fairly sure that we can fix > #264 (ABP attributes are added to every element in contentEditable elements) > with some COM tricks and a wrapper class around IHTMLElement.
6 {	9 {

7 std::wstring installed_version_string();	10 std::wstring InstalledVersionString();

8 int installed_major_version();	11 int InstalledMajorVersion();

9 }	12 }

10 }	13 }

	14

	15 #endif

LEFT	RIGHT