Delta Between Two Patch Sets: src/shared/IE_version.h
Issue 5171515343503360:
Issue #41 - Bring method of determining IE version up to date (Closed)
Left Patch Set: simplify Registry_Key
Created July 26, 2014, 5 p.m.
Right Patch Set: Final (?) 2
Created Jan. 5, 2015, 1:02 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« src/plugin/PluginWbPassThrough.cpp ('K')
|
« src/plugin/PluginWbPassThrough.cpp ('k')
|
src/shared/IE_version.cpp » ('j')
|
test/RegistryTest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 #ifndef IE_VERSION_H | |
| 2 #define IE_VERSION_H | |
| 3 | |
| 1 #include <string> | 4 #include <string> |
|
sergei
2014/07/28 11:46:27
Where is the guard?
Eric
2014/07/29 12:42:25
Yep. It needs one.
| |
| 2 | 5 |
| 3 namespace AdblockPlus | 6 namespace AdblockPlus |
| 4 { | 7 { |
| 5 namespace IE | 8 namespace IE |
| 6 { | 9 { |
| 7 std::wstring installed_version_string(); | 10 std::wstring InstalledVersionString(); |
|
sergei
2014/07/28 11:46:27
That's not our convention, InstalledVesionAsString
| |
| 8 int installed_major_version(); | 11 int InstalledMajorVersion(); |
| 9 } | 12 } |
| 10 } | 13 } |
| 14 | |
| 15 #endif | |
| LEFT | RIGHT |
« src/plugin/PluginWbPassThrough.cpp ('k')
|
src/shared/IE_version.cpp » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
