Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginClass.cpp

Issue 5171515343503360: Issue #41 - Bring method of determining IE version up to date (Closed)
Patch Set: Created June 21, 2014, 8:25 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/PluginClass.cpp
===================================================================
--- a/src/plugin/PluginClass.cpp
+++ b/src/plugin/PluginClass.cpp
@@ -667,15 +667,12 @@
}
else
{
- if (CPluginClient::GetInstance()->GetIEVersion() > 6)
Oleksandr 2014/06/22 21:53:17 IIRC IE6 was not starting at all if these checks w
Eric 2014/06/25 18:52:02 Exactly. You and I spoke about this, and it becam
+ RECT rect;
+ BOOL rectRes = GetClientRect(m_hStatusBarWnd, &rect);
+ if (rectRes == TRUE)
{
- RECT rect;
- BOOL rectRes = GetClientRect(m_hStatusBarWnd, &rect);
- if (rectRes == TRUE)
- {
- MoveWindow(m_hPaneWnd, rect.right - 200, 0, m_nPaneWidth, rect.bottom - rect.top, TRUE);
- }
- }
+ MoveWindow(m_hPaneWnd, rect.right - 200, 0, m_nPaneWidth, rect.bottom - rect.top, TRUE);
+ }
}
break;
case DISPID_STATUSTEXTCHANGE:
@@ -823,25 +820,15 @@
}
}
-
- int ieVersion = CPluginClient::GetInstance()->GetIEVersion();
// Create status pane
- if (bBHO && ieVersion > 6 && !CreateStatusBarPane())
+ if (bBHO && !CreateStatusBarPane())
{
return false;
}
if (CPluginClient::GetInstance()->IsFirstRun())
{
- // IE6 can't be accessed from another thread, execute in current thread
- if (ieVersion < 7)
- {
- FirstRunThread();
- }
- else
- {
- CreateThread(NULL, NULL, (LPTHREAD_START_ROUTINE)CPluginClass::FirstRunThread, NULL, NULL, NULL);
- }
+ CreateThread(NULL, NULL, (LPTHREAD_START_ROUTINE)CPluginClass::FirstRunThread, NULL, NULL, NULL);
if ((m_hPaneWnd == NULL) || (!IsStatusBarEnabled()))
{
ShowStatusBar();

Powered by Google App Engine
This is Rietveld