Issue 2234 - Add a WSGI controller to collect email addresses for the Adblock Browser iOS launch

sitescripts/submit_email/web/submit_email.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2015 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 import fcntl
 import hmac
 import hashlib
 import wsgiref.util
 from urlparse import parse_qsl, urljoin
-from urllib import urlencode
+from urllib import urlencode, quote
 
 from sitescripts.utils import get_config, sendMail, encode_email_address
 from sitescripts.web import url_handler, form_handler, send_simple_response
 
 VERIFICATION_PATH = '/verifyEmail'
 
 def sign(config, data):
   secret = config.get('submit_email', 'secret')
   return hmac.new(secret, data, hashlib.sha1).hexdigest()
 
@@ skipping 47 matching lines @@
 
   filename = config.get('submit_email', 'filename')
   with open(filename, 'ab', 0) as file:
     fcntl.lockf(file, fcntl.LOCK_EX)
     try:
       print >>file, email
     finally:
       fcntl.lockf(file, fcntl.LOCK_UN)
 
   location = config.get('submit_email', 'successful_verification_redirect_location')
-  location = location.format(lang=params.get('lang', 'en'))
+  location = location.format(lang=quote(params.get('lang') or 'en', ''))

[kzar, 2015/04/28 11:13:42]

Looks like a typo at the end there? ", ''"

[Sebastian Noack, 2015/04/28 11:31:25]

The empty string at the end is the second argument to quote() to make it escape
backslashes as well.

[kzar, 2015/04/28 11:33:41]

Oh I see.

[Sebastian Noack, 2015/04/28 11:36:04]

I meant (forward) slashes.

   start_response('303 See Other', [('Location', location)])
   return []