Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5183241912844288: Issue 380 - Fixed width of bubble in Safari with long translated texts (Closed)

Created:
April 26, 2014, 1:34 p.m. by Sebastian Noack
Modified:
April 30, 2014, 3:45 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 380 - Fixed width of bubble in Safari with long translated texts

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M popup.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M safari/ext/popup.js View 1 2 chunks +11 lines, -1 line 0 comments Download
M skin/popup.css View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
http://codereview.adblockplus.org/5183241912844288/diff/5629499534213120/popup.html File popup.html (right): http://codereview.adblockplus.org/5183241912844288/diff/5629499534213120/popup.html#newcode68 popup.html:68: <div class="collapse-icon-placeholder safari-only"></div> Safari ignores the padding of surrounding ...
April 26, 2014, 1:39 p.m. (2014-04-26 13:39:37 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5183241912844288/diff/5629499534213120/chrome/ext/popup.js File chrome/ext/popup.js (right): http://codereview.adblockplus.org/5183241912844288/diff/5629499534213120/chrome/ext/popup.js#newcode4 chrome/ext/popup.js:4: document.head.appendChild(style); The assumption here is that it is either ...
April 30, 2014, 1:57 p.m. (2014-04-30 13:57:57 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5183241912844288/diff/5629499534213120/chrome/ext/popup.js File chrome/ext/popup.js (right): http://codereview.adblockplus.org/5183241912844288/diff/5629499534213120/chrome/ext/popup.js#newcode4 chrome/ext/popup.js:4: document.head.appendChild(style); On 2014/04/30 13:57:57, Wladimir Palant wrote: > The ...
April 30, 2014, 3:37 p.m. (2014-04-30 15:37:48 UTC) #3
Wladimir Palant
April 30, 2014, 3:41 p.m. (2014-04-30 15:41:53 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld