chrome/ext/popup.js - Issue 5183241912844288: Issue 380 - Fixed width of bubble in Safari with long translated texts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: chrome/ext/popup.js

Issue 5183241912844288: Issue 380 - Fixed width of bubble in Safari with long translated texts (Closed)

Patch Set: Created April 26, 2014, 1:34 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 window.ext = {	1 (function() {

2 __proto__: chrome.extension.getBackgroundPage().ext,	2 var style = document.createElement("style");

	3 style.textContent = ".safari-only { display: none; }";

	4 document.head.appendChild(style);
	Wladimir Palant 2014/04/30 13:57:57 The assumption here is that it is either Safari or The assumption here is that it is either Safari or Chrome - no other platforms, ever. Please add this rule to popup.css and override it with display:inline-block in safari/ext/popup.js (with a comment explaining why this hack is necessary in the first place). Sebastian Noack 2014/04/30 15:37:48 Done. Show quoted text On 2014/04/30 13:57:57, Wladimir Palant wrote: > The assumption here is that it is either Safari or Chrome - no other platforms, > ever. Please add this rule to popup.css and override it with > display:inline-block in safari/ext/popup.js (with a comment explaining why this > hack is necessary in the first place). Done.
3	5

4 closePopup: function()	6 window.ext = {

5 {	7 __proto__: chrome.extension.getBackgroundPage().ext,

6 window.close();	8

7 }	9 closePopup: function()

8 };	10 {

	11 window.close();

	12 }

	13 };

	14 })();

OLD	NEW

« no previous file with comments | « no previous file | popup.html » ('j') | popup.html » ('J')