Issue 1843 - Deactivate "Block element" dialog when extension is disabled/uninstalled/reloaded

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 373 matching lines @@
           }
 
           return frames[0];
         }
       }
     };
 
     return ext.onMessage._dispatch(message, sender, sendResponse).indexOf(true) != -1;
   });
 
-  // We have to register any listener for the onConnect event. Otherwise
-  // you can't connect any ports. However, we need to connect from the
-  // content script, in order to detect extension reload/disable/uninstall.
+  // We have to ensure there is at least one listener for the onConnect event.
+  // Otherwise we can't connect a port later, which we need to do in order to
+  // detect when the extension is reloaded, disabled or uninstalled.
   chrome.runtime.onConnect.addListener(function() {});

[kzar, 2015/01/26 16:05:22]

The comment doesn't read quite right, how about this? "We have to ensure there
is at least one listener for the onConnect event. Otherwise we can't connect a
port later, which we need to do in order to detect when the extension is
reloaded, disabled or uninstalled."

[Sebastian Noack, 2015/01/26 16:13:56]

Doesn't read that much differently for me. But I guess you know what you are
doing. ;) I updated the comment to use your version.

 
 
   /* Storage */
 
   ext.storage = localStorage;
 
 
   /* Options */
 
   ext.showOptions = function(callback)
@@ skipping 28 matching lines @@
             callback(new Page(tab));
         }
         else
         {
           ext.pages.open(optionsUrl, callback);
         }
       });
     });
   };
 })();