Issue #1234 - Rewrite internals of debug facility

src/plugin/PluginTabBase.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 321 matching lines @@
       m_cacheFrames.clear();
       m_cacheDomain = domain;
     }
   }
   m_criticalSectionCache.Unlock();
 }
 
 void CPluginTabBase::ThreadProc()
 {
   // Force loading/creation of settings
-  CPluginSettings::GetInstance()->SetWorkingThreadId();
+  CPluginSettings::GetInstance();

[Oleksandr, 2015/11/25 04:42:30]

Nit: This is a dummy call now. Note, the comment is misleading. Its here from
the old days when we were using the settings.ini for initialization.

[Eric, 2015/11/25 17:41:17]

This whole function is going away, including the comment and the dummy call. See
the following review:
   
https://codereview.adblockplus.org/29323611/diff/29324420/src/plugin/PluginTa...

If we change it here, it just means dealing later with a merge conflict or
making new patch sets. Doesn't seem worth it to change here at this point.

 
   std::string message =
     "================================================================================\n"
     "TAB THREAD process=";
   message += std::to_string(::GetCurrentProcessId());
   message + " thread=";
   message += std::to_string(::GetCurrentThreadId());
   message +=
     "\n"
     "================================================================================";
@@ skipping 32 matching lines @@
           LogQueue::LogPluginError(pluginError.GetErrorCode(), pluginError.GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), true, pluginError.GetProcessId(), pluginError.GetThreadId());
         }
 
         // Non-hanging sleep
         Sleep(50);
       }
 
       tabLoopIteration++;
   }
 }