src/plugin/PluginTabBase.cpp - Issue 5187613258416128: Issue #1234 - Rewrite internals of debug facility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/plugin/PluginTabBase.cpp

Issue 5187613258416128: Issue #1234 - Rewrite internals of debug facility (Closed)

Patch Set: add virtual destructor to LogText Created Nov. 18, 2015, 12:35 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/plugin/PluginTabBase.cpp

===================================================================

--- a/src/plugin/PluginTabBase.cpp

+++ b/src/plugin/PluginTabBase.cpp

@@ -339,7 +339,7 @@

void CPluginTabBase::ThreadProc()

{

// Force loading/creation of settings

- CPluginSettings::GetInstance()->SetWorkingThreadId();

+ CPluginSettings::GetInstance();

Oleksandr 2015/11/25 04:42:30 Nit: This is a dummy call now. Note, the comment i

Eric 2015/11/25 17:41:17 This whole function is going away, including the c

std::string message =

"================================================================================\n"

« no previous file with comments | « src/plugin/PluginStdAfx.h ('k') | no next file » | no next file with comments »