Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 5193970430771200: Issue 1363 - Make sure source code archives created by release automation consider the new dependen… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by Wladimir Palant
Modified:
5 years, 5 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 1363 - Make sure source code archives created by release automation consider the new dependen…

Patch Set 1 #

Total comments: 7

Patch Set 2 : Addressed comments #

Patch Set 3 : Addressed remaining comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M releaseAutomation.py View 1 2 2 chunks +32 lines, -15 lines 0 comments Download

Messages

Total messages: 7
Wladimir Palant
5 years, 5 months ago (2014-09-11 19:06:05 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py File releaseAutomation.py (right): http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py#newcode24 releaseAutomation.py:24: with open(output, 'wb') as handle: You can just pass ...
5 years, 5 months ago (2014-09-18 16:20:06 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py File releaseAutomation.py (right): http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py#newcode30 releaseAutomation.py:30: with tarfile.open(fileobj=StringIO(data), mode='r:') as repoarchive: On 2014/09/18 16:20:06, Sebastian ...
5 years, 5 months ago (2014-09-18 16:21:23 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py File releaseAutomation.py (right): http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py#newcode24 releaseAutomation.py:24: with open(output, 'wb') as handle: Done, don't remember why ...
5 years, 5 months ago (2014-09-18 18:40:47 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py File releaseAutomation.py (right): http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py#newcode30 releaseAutomation.py:30: with tarfile.open(fileobj=StringIO(data), mode='r:') as repoarchive: On 2014/09/18 18:40:48, Wladimir ...
5 years, 5 months ago (2014-09-18 18:58:12 UTC) #5
Wladimir Palant
http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py File releaseAutomation.py (right): http://codereview.adblockplus.org/5193970430771200/diff/5629499534213120/releaseAutomation.py#newcode30 releaseAutomation.py:30: with tarfile.open(fileobj=StringIO(data), mode='r:') as repoarchive: On 2014/09/18 18:58:12, Sebastian ...
5 years, 5 months ago (2014-09-18 19:23:57 UTC) #6
Sebastian Noack
5 years, 5 months ago (2014-09-18 20:43:50 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5