metadata.common - Issue 5196306347720704: Issue 1965 - Simplified and fixed missing image for icon animation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 5196306347720704: Issue 1965 - Simplified and fixed missing image for icon animation (Closed)

Left Patch Set: Created March 7, 2014, 5:28 p.m.

Right Patch Set: Rebased and addressed comment Created Feb. 12, 2015, 11:15 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 [general]	1 [general]

2 version = 1.8.10	2 version = 1.8.10

3 backgroundScripts = ext/common.js	3 backgroundScripts = ext/common.js

4 ext/background.js	4 ext/background.js

5 lib/compat.js	5 lib/compat.js

6 lib/info.js	6 lib/info.js

7 lib/io.js	7 lib/io.js

8 lib/adblockplus.js	8 lib/adblockplus.js

9 lib/punycode.js	9 lib/punycode.js

10 lib/publicSuffixList.js	10 lib/publicSuffixList.js

11 lib/sha1.js	11 lib/sha1.js

12 lib/jsbn.js	12 lib/jsbn.js

13 lib/rsa.js	13 lib/rsa.js

14 webrequest.js	14 webrequest.js

15 messageResponder.js	15 messageResponder.js

16 popupBlocker.js	16 popupBlocker.js

17 iconAnimation.js

18 background.js	17 background.js

19 permissions = http:/// https:///	18 permissions = http:/// https:///

20	19

21 [contentScripts]	20 [contentScripts]

22 document_start = ext/common.js ext/content.js include.preload.js	21 document_start = ext/common.js ext/content.js include.preload.js

23 document_end = include.postload.js	22 document_end = include.postload.js

24	23

25 [mapping]	24 [mapping]

26 ext/content.js = chrome/ext/content.js	25 ext/content.js = chrome/ext/content.js

27 ext/popup.js = chrome/ext/popup.js	26 ext/popup.js = chrome/ext/popup.js

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 adblockplus/lib/elemHide.js	61 adblockplus/lib/elemHide.js

63 adblockplus/lib/matcher.js	62 adblockplus/lib/matcher.js

64 adblockplus/lib/filterListener.js	63 adblockplus/lib/filterListener.js

65 adblockplus/lib/synchronizer.js	64 adblockplus/lib/synchronizer.js

66 adblockplus/lib/notification.js	65 adblockplus/lib/notification.js

67 adblockplus/lib/antiadblockInit.js	66 adblockplus/lib/antiadblockInit.js

68 lib/url.js	67 lib/url.js

69 lib/stats.js	68 lib/stats.js

70 lib/whitelisting.js	69 lib/whitelisting.js

71 lib/filterValidation.js	70 lib/filterValidation.js

	71 lib/icon.js

72 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/	72 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/

73 ext/common.js = ext/common.js chrome/ext/common.js	73 ext/common.js = ext/common.js chrome/ext/common.js

74 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand	74 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand

75	75

76 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js	76 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js

77 adblockplustests/chrome/content/tests/filterClasses.js	77 adblockplustests/chrome/content/tests/filterClasses.js

78 adblockplustests/chrome/content/tests/filterNotifier.js	78 adblockplustests/chrome/content/tests/filterNotifier.js

79 adblockplustests/chrome/content/tests/filterStorage.js	79 adblockplustests/chrome/content/tests/filterStorage.js

80 adblockplustests/chrome/content/tests/matcher.js	80 adblockplustests/chrome/content/tests/matcher.js

81 adblockplustests/chrome/content/tests/prefs.js	81 adblockplustests/chrome/content/tests/prefs.js

(...skipping 22 matching lines...) Expand all Loading...
104 addSubscription.label	104 addSubscription.label

105 addSubscriptionAdd.label	105 addSubscriptionAdd.label

106 addSubscriptionOther.label	106 addSubscriptionOther.label

107 acceptableAds2.label	107 acceptableAds2.label

108 viewList.label	108 viewList.label

109 readMore.label	109 readMore.label

110 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	110 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

111 title.label	111 title.label

112 adblockplus/chrome/locale/*/meta.properties = =name	112 adblockplus/chrome/locale/*/meta.properties = =name

113 adblockplusui/locale//firstRun.json = =	113 adblockplusui/locale//firstRun.json = =

LEFT	RIGHT