Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5197857351008256: Issue 343 - Fix element collapsing in Chrome 35 (Closed)

Created:
April 17, 2014, 10:39 a.m. by Sebastian Noack
Modified:
April 17, 2014, 1:34 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Element collapsing is currently broken in Chrome 35. That is because we pass "!important" as second parameter to el.style.setProperty(). However the leading exclamation mark must be omitted. It seems that older Chrome versions where more tolerant here.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include.preload.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
April 17, 2014, 10:53 a.m. (2014-04-17 10:53:43 UTC) #1
Felix Dahlke
April 17, 2014, 12:02 p.m. (2014-04-17 12:02:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld