lib/ui.js - Issue 5198627827875840: Issue 424 - Anti-adblock filterlist disabled on extension update (Firefox)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/ui.js

Issue 5198627827875840: Issue 424 - Anti-adblock filterlist disabled on extension update (Firefox) (Closed)

Patch Set: Created May 5, 2014, 2:30 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/ui.js

===================================================================

--- a/lib/ui.js

+++ b/lib/ui.js

@@ -795,14 +795,17 @@

addAcceptable = false;

}

- // Add "anti-adblock messages" subscription

- let subscription = Subscription.fromURL(Prefs.subscriptions_antiadblockurl);

- if (subscription)

+ // Add "anti-adblock messages" subscription on first run

+ if (Services.vc.compare(prevVersion, "0.0") == 0)

{

- subscription.disabled = true;

- FilterStorage.addSubscription(subscription);

- if (subscription instanceof DownloadableSubscription && !subscription.lastDownload)

- Synchronizer.execute(subscription);

+ let subscription = Subscription.fromURL(Prefs.subscriptions_antiadblockurl);

+ if (subscription)

+ {

+ subscription.disabled = true;

+ FilterStorage.addSubscription(subscription);

+ if (subscription instanceof DownloadableSubscription && !subscription.lastDownload)

+ Synchronizer.execute(subscription);

+ }

}

if (!addSubscription && !addAcceptable)

« no previous file with comments | « no previous file | no next file » | no next file with comments »