Issue 2040 - Adapted tests for chrome.storage.local

chrome/content/tests/prefs.js

 (function()
 {
   module("Preferences",
   {
     setup: function()
     {
       preparePrefs.call(this);
     },
 
     teardown: function()
     {
       restorePrefs.call(this);
     }
   });
 
   function checkPrefExists(name, expectedValue, description, assert)
   {
     if ("chrome" in window)

[Wladimir Palant, 2015/02/26 14:43:11]

Looks like this test doesn't consider Safari. Is there already an issue to get
the Safari implementation tested as well?

[Sebastian Noack, 2015/02/26 16:03:43]

Tests are currently and ever since pretty much broken on Safari. The largest
issue there is that we can't access the background page there, at least if want
to get rid of the messaging proxy. Also some extension APIs that can be accessed
from extension pages on Chrome, can only be accessed from the background page on
Safari.

So eventually, if we want to run tests on Safari, we have to run the tests in
the background page, showing the results somehow on a page. I have the feeling
that this is getting difficult to impossible with QUnit.

     {
       let done = assert.async();
-          let key = "pref:" + name;

[Wladimir Palant, 2015/02/26 14:43:11]

Nit: no smart tabs please.

[Sebastian Noack, 2015/02/26 16:03:43]

Just regular tabs. I'm still not a fan of spaces. So I manually switch from tabs
to spaces when working on our files, and apparently forgot once. ;)

-      chrome.storage.local.get([key], function(items)

[Wladimir Palant, 2015/02/26 14:43:11]

According to documentation, passing in key without wrapping it in an array
should work as well.

[Sebastian Noack, 2015/02/26 16:03:43]

Yes, it does, but I find it weird. Since you always get an object of
key-value-pairs in the callback, it's kinda inconsistent when passing an
integral. But I don't mind, changed it.

+      let key = "pref:" + name;
+      chrome.storage.local.get(key, function(items)
       {
         equal(key in items, expectedValue, description);
         done();
       });
     }
     else
     {
       equal(Services.prefs.prefHasUserValue("extensions.adblockplus." + name), expectedValue, description);
     }
   }
 
   function checkPref(name, expectedValue, description, assert)
   {
     if ("chrome" in window)
     {
       let done = assert.async();
-          let key = "pref:" + name;

[Wladimir Palant, 2015/02/26 14:43:11]

Nit: no smart tabs please.

[Sebastian Noack, 2015/02/26 16:03:43]

Done, here as well.

-      chrome.storage.local.get([key], function(items)

[Wladimir Palant, 2015/02/26 14:43:11]

As above, passing in key without wrapping it in an array should work as well.

[Sebastian Noack, 2015/02/26 16:03:43]

Done, here as wel.

+      let key = "pref:" + name;
+      chrome.storage.local.get(key, function(items)
       {
         deepEqual(items[key], expectedValue, description);
         done();
       });
     }
     else
     {
       let pref = "extensions.adblockplus." + name;
       let value = null;
 
@@ skipping 75 matching lines @@
     deepEqual(Prefs.notificationdata, {foo:1, bar: 2}, "Prefs object returns the correct value after setting pref to non-default value");
     checkPrefExists("notificationdata", true, "User-defined pref has been created", assert);
     checkPref("notificationdata", {foo:1, bar: 2}, "Value has been written", assert);
 
     delete Prefs.notificationdata.foo;
     delete Prefs.notificationdata.bar;
     Prefs.notificationdata = JSON.parse(JSON.stringify(Prefs.notificationdata));
     deepEqual(Prefs.notificationdata, {}, "Prefs object returns the correct value after setting pref to default value");
   });
 })();