Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5203459900964864: Issue 492 - Implemented popup blocking for Safari (Closed)

Created:
May 16, 2014, 9:46 a.m. by Sebastian Noack
Modified:
Oct. 13, 2015, 2:35 p.m.
Reviewers:
Thomas Greiner
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 492 - Implemented popup blocking for Safari

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -104 lines) Patch
M chrome/ext/background.js View 3 chunks +36 lines, -1 line 0 comments Download
M popupBlocker.js View 1 chunk +9 lines, -44 lines 0 comments Download
M safari/ext/background.js View 4 chunks +81 lines, -58 lines 0 comments Download
M safari/ext/content.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
Sebastian Noack
May 16, 2014, 10:02 a.m. (2014-05-16 10:02:58 UTC) #1
Sebastian Noack
Sept. 16, 2015, 6:50 a.m. (2015-09-16 06:50:19 UTC) #2
Closing this review unmerged now. This patch is almost 1,5 years old by now and
would require some refactoring to merge. Something that is extremely unlikely to
happen any time soon. Plus, the new content blocker API, available in Safari 9,
might provide a better way to implement popup blocking now.

Powered by Google App Engine
This is Rietveld