Issue #1186 - Change names that appear in the custom action

installer/src/installer-lib/session.h

 /**
 * \file session.h The "install session" is the context for all custom installation behavior.
 */
 
 #ifndef SESSION_H
 #define SESSION_H
 
 #include "property.h"
 #include "record.h"
 
@@ skipping 78 matching lines @@
   * Write a message to the installation log without raising an exception.
   *
   * Use this function only in the three circumstances when an exception cannot be caught by an entry point catch-all.
   * First and second, there's the constructor and destructor of a Session instance.
   * These log entry into and exit from the custom action, respectively.
   * Third, there's the top level catch-blocks of the CA.
   * The scope of the Session object cannot be within the try-block in order for it to be in scope for the catch-block.
   * The session must be in scope in the catch-block to allow logging error messages.
   * In all other cases, use the exception mechanism.
   */
-  void log_noexcept( std::string message ) ;
+  void LogNoexcept( std::string message ) ;
 
   /**
   * Write to a MessageBox dialog.
   */
-  int write_message( Message & ) ;
+  int WriteMessage( Message & ) ;
 
 protected:
   /**
   * Ordinary constructor is protected; public constructors are all in subclasses.
   * The MSI system uses a single handle type for all types of sessions. This handle is here in this base class.
   *
   * \param[in] handle
   *    Handle for the Windows Installer session provided as an argument to a custom action.
   * \param[in] name
   *    The name of the custom action, used for logging.
@@ skipping 44 matching lines @@
   */
   Session & operator=( const Session & ) ;
 
   /**
   * The Property class requires access to the session handle.
   */
   friend Property::Property( Session & session, std::wstring name ) ;
 };
 
 //-----------------------------------------------------------------------------------------
-// Immediate_Session
+// ImmediateSession
 //-----------------------------------------------------------------------------------------
 /**
 * Session for immediate custom actions.
 *
 * Access to the installer database is by passing a reference to a class of this subtype to a Database constructor.
 */
-class Immediate_Session : public Session
+class ImmediateSession : public Session
 {
 public:
   /**
   * Ordinary constructor.
   *
   * \param[in] handle
   *    Handle for the Windows Installer session provided as an argument to a custom action.
   * \param[in] name
   *    The name of the custom action, used for logging.
   * 
   * **noexcept** declaration to be added for C++11.
   */
-  Immediate_Session( MSIHANDLE handle, std::string name ) ;
+  ImmediateSession( MSIHANDLE handle, std::string name ) ;
 
 private:
   /*
   * Allow helper function for Installation_Database constructor to have access to the handle.
   */
-  friend msi_handle get_active_database( Immediate_Session & session ) ;
+  friend msi_handle get_active_database( ImmediateSession & session ) ;
 };
 
 
 //-----------------------------------------------------------------------------------------
 // Deferred_Session
 //-----------------------------------------------------------------------------------------
 /**
 * Session for deferred custom actions.
 *
 * There's much less context information easily available from a deferred custom action.
@@ skipping 39 matching lines @@
 /**
 * The session for a rollback custom action. NOT IMPLEMENTED.
 *
 * \sa MSDN "Rollback Custom Actions" http://msdn.microsoft.com/en-us/library/windows/desktop/aa371369%28v=vs.85%29.aspx
 */
 class Rollback_Session
 {
 };
 
 #endif