chrome/ext/popup.js - Issue 5220277533278208: Made the bubble use the ext object from the background page instead of including ext/background.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: chrome/ext/popup.js

Issue 5220277533278208: Made the bubble use the ext object from the background page instead of including ext/background.js (Closed)

Patch Set: Created Dec. 21, 2013, 7:12 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 with (chrome.extension.getBackgroundPage())

	2 {

	3 this.ext = ext;

	4 this.TabMap = TabMap;

	5 }
	Wladimir Palant 2014/01/15 16:39:19 Please don't use the with statement, it is depreca Please don't use the with statement, it is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...). There is nothing wrong with assigning to a temp variable. Sebastian Noack 2014/01/15 16:55:21 Done. Show quoted text On 2014/01/15 16:39:19, Wladimir Palant wrote: > Please don't use the with statement, it is deprecated (see > https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/...). > There is nothing wrong with assigning to a temp variable. Done.
OLD	NEW

« no previous file with comments | « no previous file | metadata.common » ('j') | safari/ext/background.js » ('J')