metadata.common - Issue 5220277533278208: Made the bubble use the ext object from the background page instead of including ext/background.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: metadata.common

Issue 5220277533278208: Made the bubble use the ext object from the background page instead of including ext/background.js (Closed)

Patch Set: Created Dec. 21, 2013, 7:12 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [general]	1 [general]

2 backgroundScripts = ext/common.js	2 backgroundScripts = ext/common.js

3 ext/background.js	3 ext/background.js

4 lib/compat.js	4 lib/compat.js

5 lib/info.js	5 lib/info.js

6 lib/io.js	6 lib/io.js

7 lib/adblockplus.js	7 lib/adblockplus.js

8 lib/punycode.js	8 lib/punycode.js

9 lib/publicSuffixList.js	9 lib/publicSuffixList.js

10 lib/basedomain.js	10 lib/basedomain.js

11 lib/sha1.js	11 lib/sha1.js

12 lib/jsbn.js	12 lib/jsbn.js

13 lib/rsa.js	13 lib/rsa.js

14 webrequest.js	14 webrequest.js

15 popupBlocker.js	15 popupBlocker.js

16 iconAnimation.js	16 iconAnimation.js

17 background.js	17 background.js

18 permissions = http:/// https:///	18 permissions = http:/// https:///

19	19

20 [contentScripts]	20 [contentScripts]

21 document_start = ext/common.js ext/content.js include.preload.js	21 document_start = ext/common.js ext/content.js include.preload.js

22 document_end = include.postload.js	22 document_end = include.postload.js

23	23

24 [mapping]	24 [mapping]

25 ext/common.js = chrome/ext/common.js	25 ext/common.js = chrome/ext/common.js

26 ext/background.js = chrome/ext/background.js	26 ext/background.js = chrome/ext/background.js

27 ext/content.js = chrome/ext/content.js	27 ext/content.js = chrome/ext/content.js

	28 ext/popup.js = chrome/ext/popup.js

28 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml	29 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml

29 firstRun.html = adblockplus/chrome/content/ui/firstRun.html	30 firstRun.html = adblockplus/chrome/content/ui/firstRun.html

30 firstRun.js = adblockplus/chrome/content/ui/firstRun.js	31 firstRun.js = adblockplus/chrome/content/ui/firstRun.js

31 i18n.js = adblockplus/chrome/content/ui/i18n.js	32 i18n.js = adblockplus/chrome/content/ui/i18n.js

32 skin/firstRun.css = adblockplus/chrome/skin/firstRun.css	33 skin/firstRun.css = adblockplus/chrome/skin/firstRun.css

33 skin/abp-icon-big.png = adblockplus/chrome/skin/abp-icon-big.png	34 skin/abp-icon-big.png = adblockplus/chrome/skin/abp-icon-big.png

34 skin/ajax-loader.gif = adblockplus/chrome/skin/ajax-loader.gif	35 skin/ajax-loader.gif = adblockplus/chrome/skin/ajax-loader.gif

35 skin/background.png = adblockplus/chrome/skin/background.png	36 skin/background.png = adblockplus/chrome/skin/background.png

36 skin/background-main.png = adblockplus/chrome/skin/background-main.png	37 skin/background-main.png = adblockplus/chrome/skin/background-main.png

37 skin/background-share.png = adblockplus/chrome/skin/background-share.png	38 skin/background-share.png = adblockplus/chrome/skin/background-share.png

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 addSubscription.label	94 addSubscription.label

94 addSubscriptionAdd.label	95 addSubscriptionAdd.label

95 addSubscriptionOther.label	96 addSubscriptionOther.label

96 acceptableAds2.label	97 acceptableAds2.label

97 viewList.label	98 viewList.label

98 readMore.label	99 readMore.label

99 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	100 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

100 title.label	101 title.label

101 adblockplus/chrome/locale/*/meta.properties = =name	102 adblockplus/chrome/locale/*/meta.properties = =name

102 adblockplus/chrome/locale//firstRun.properties = =	103 adblockplus/chrome/locale//firstRun.properties = =

OLD	NEW

« chrome/ext/popup.js ('K') | « chrome/ext/popup.js ('k') | metadata.safari » ('j') | safari/ext/background.js » ('J')