chrome/ext/popup.js - Issue 5220277533278208: Made the bubble use the ext object from the background page instead of including ext/background.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: chrome/ext/popup.js

Issue 5220277533278208: Made the bubble use the ext object from the background page instead of including ext/background.js (Closed)

Patch Set: Don't use with statement Created Jan. 15, 2014, 4:53 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 (function()

	2 {

	3 var backgroundPage = chrome.extension.getBackgroundPage();

	4 ext = backgroundPage.ext;

	5 TabMap = backgroundPage.TabMap;
	Wladimir Palant 2014/01/16 07:46:43 Assigning to undeclared variables isn't the fine a Assigning to undeclared variables isn't the fine art either. You need either \|var ext, TabMap\| before this function or assign to window.ext and window.TabMap.
	6 })();

OLD	NEW

« no previous file with comments | « no previous file | metadata.common » ('j') | no next file with comments »