Delta Between Two Patch Sets: chrome/ext/popup.js
Issue 5220277533278208:
Made the bubble use the ext object from the background page instead of including ext/background.js (Closed)
Left Patch Set:
Created Dec. 21, 2013, 7:12 p.m.
Right Patch Set: Assigned imported variables to window
Created Jan. 16, 2014, 10:49 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
metadata.common » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 with (chrome.extension.getBackgroundPage()) | 1 (function() |
| 2 { | 2 { |
| 3 this.ext = ext; | 3 var backgroundPage = chrome.extension.getBackgroundPage(); |
| 4 this.TabMap = TabMap; | 4 window.ext = backgroundPage.ext; |
| 5 } | 5 window.TabMap = backgroundPage.TabMap; |
|
Wladimir Palant
2014/01/15 16:39:19
Please don't use the with statement, it is depreca
Sebastian Noack
2014/01/15 16:55:21
Done.
| |
| 6 })(); | |
| LEFT | RIGHT |
« no previous file
|
metadata.common » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
