Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/ext/popup.js

Issue 5220277533278208: Made the bubble use the ext object from the background page instead of including ext/background.js (Closed)
Left Patch Set: Rebased and moved imports to the bottom Created Jan. 15, 2014, 4:38 p.m.
Right Patch Set: Assigned imported variables to window Created Jan. 16, 2014, 10:49 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | metadata.common » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 with (chrome.extension.getBackgroundPage()) 1 (function()
2 { 2 {
3 this.ext = ext; 3 var backgroundPage = chrome.extension.getBackgroundPage();
4 this.TabMap = TabMap; 4 window.ext = backgroundPage.ext;
5 } 5 window.TabMap = backgroundPage.TabMap;
6 })();
LEFTRIGHT
« no previous file | metadata.common » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld