Issue 1282 - Don't generate filters conflicting with existing exception rules

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 537 matching lines @@
     case "add-sitekey":
       processKey(msg.token, sender.page, sender.frame);
       break;
     case "report-html-page":
       htmlPages.set(sender.page, null);
       refreshIconAndContextMenu(sender.page);
       break;
     case "compose-filters":
       sendResponse(composeFilters(
         msg.tagName, msg.id, msg.src, msg.style,
-        msg.classes, msg.urls, new URL(msg.baseURL)
+        msg.classes, msg.urls, msg.mediatype,
+        msg.baseURL, sender.page, sender.frame

[Wladimir Palant, 2015/03/02 20:14:19]

Ten positional parameters in a function is certainly a reason to worry. Normally
you would turn the parameters into a dictionary but in this particular case -
maybe pass in msg and sender directly?

[Sebastian Noack, 2015/03/03 14:29:00]

How about reducing the number of arguments by grouping the element's attributes
into an object?

[Wladimir Palant, 2015/03/03 14:40:31]

That's eight parameters now - still way too many to be passed by position for my
taste.

[Sebastian Noack, 2015/03/03 14:59:28]

Fair enough.

       ));
       break;
     case "forward":
       if (sender.page)
       {
         if (msg.expectsResponse)
         {
           sender.page.sendMessage(msg.payload, sendResponse);
           return true;
         }
@@ skipping 10 matching lines @@
   page.sendMessage({type: "clickhide-deactivate"});
   refreshIconAndContextMenu(page);
 });
 
 setTimeout(function()
 {
   var notificationToShow = NotificationStorage.getNextToShow();
   if (notificationToShow)
     showNotification(notificationToShow);
 }, 3 * 60 * 1000);