background.js - Issue 5225119261655040: Issue 1282 - Don't generate filters conflicting with existing exception rules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: background.js

Issue 5225119261655040: Issue 1282 - Don't generate filters conflicting with existing exception rules (Closed)

Patch Set: Addressed comment Created March 3, 2015, 2:59 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: background.js

===================================================================

--- a/background.js

+++ b/background.js

@@ -553,10 +553,18 @@

refreshIconAndContextMenu(sender.page);

break;

case "compose-filters":

- sendResponse(composeFilters(

- msg.tagName, msg.id, msg.src, msg.style,

- msg.classes, msg.urls, new URL(msg.baseURL)

- ));

+ sendResponse(composeFilters({

+ tagName: msg.tagName,

+ id: msg.id,

+ src: msg.src,

+ style: msg.style,

+ classes: msg.classes,

+ urls: msg.urls,

+ type: msg.mediatype,

+ baseURL: msg.baseURL,

+ page: sender.page,

+ frame: sender.frame

+ }));

break;

case "forward":

if (sender.page)

« no previous file with comments | « no previous file | include.postload.js » ('j') | lib/filterComposer.js » ('J')