Issue 2340 - Don`t generate pages if less than 30% have been translated

cms/utils.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2015 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
-from .converters import converters, TemplateConverter
+from cms.converters import converters, TemplateConverter
 
 def get_page_params(source, locale, page, format=None, site_url_override=None):
   # Guess page format if omitted, but default to Markdown for friendlier exceptions
   if format is None:
     for format in converters.iterkeys():
       if source.has_page(page, format):
         break
     else:
       format = "md"
 
@@ skipping 24 matching lines @@
 
   # Note: The converter might change some parameters so we can only read in
   # template data here.
   params["templatedata"] = source.read_template(params["template"])
 
   defaultlocale = params["config"].get("general", "defaultlocale")
   params["defaultlocale"] = defaultlocale
 
   locales = [
     l
     for l in source.list_locales()

[Wladimir Palant, 2015/04/17 17:22:31]

Parameter being overwritten here isn't quite related, this issue made me waste
time when testing however.

     if source.has_locale(locale, localefile)
   ]
   if defaultlocale not in locales:
     locales.append(defaultlocale)
   locales.sort()
   params["available_locales"] = locales
 
   params["head"], params["body"] = converter()
-  if converter.total_translations:

[Sebastian Noack, 2015/04/17 17:32:27]

Nit: total_translation > 0

I know 0 evaluates to False. But semantically we aren't checking for presence
here, but the logic actually is about this being larger than 0.

+  if converter.total_translations > 0:
     params["translation_ratio"] = (1 -
         float(converter.missing_translations) / converter.total_translations)
   else:
     params["translation_ratio"] = 1

[Wladimir Palant, 2015/04/17 17:22:31]

Note that having this in params means that default.tmpl can access it - so we
could show a message for incomplete translations along the lines of "Help us
finish this translation on Crowdin."

 
   return params
 
-def process_page(source, locale, page, format, site_url_override=None, min_translated=0):
-  params = get_page_params(source, locale, page, format, site_url_override)
-  if params["translation_ratio"] < min_translated:
-    return None
-  else:

[Sebastian Noack, 2015/04/17 17:32:27]

Nit: Redundant else statement.

[Wladimir Palant, 2015/04/17 18:21:15]

I thought you would object to this, but I actually like redundant else
statements :)

-    return TemplateConverter(
-      params,
-      key="templatedata"
-    )()
+def process_page(source, locale, page, format=None, site_url_override=None):
+  return TemplateConverter(
+    get_page_params(source, locale, page, format, site_url_override),
+    key="templatedata"
+  )()