Issue 2072 - Don`t duplicate 128x128 icon in Chrome builds

firstRun.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 39 matching lines @@
   {
     ext.backgroundPage.sendMessage({
       type: "app.get",
       what: "doclink",
       link: link
     }, callback);
   }
 
   function onDOMLoaded()
   {
+    // Set up logo image
+    var logo = E("logo");
+    logo.src = "skin/abp-128.png";

[Sebastian Noack, 2015/03/02 14:25:02]

Can't you specify that URL in firstRun.html? DOMContentLoaded should occur
before the error event, won't it?

[Wladimir Palant, 2015/03/02 14:28:51]

No, that's not guaranteed. Over the web the browser will load and process the
document in chunks, in theory it could do the same when loading from the file
system.

+    var errorCallback = function()

[Sebastian Noack, 2015/03/02 14:25:02]

Why an anonymous function?

[Wladimir Palant, 2015/03/02 14:28:51]

What exactly are you suggesting? A global function? Seems to hurt code locality
here and not really worth it. Naming the function? The browsers are capable of
doing that themselves. Proper nested function? I consider that ugly, given that
the logo variable is being used here - the function would be declared before
that variable.

[Sebastian Noack, 2015/03/02 14:32:16]

Yes, I'm suggesting a nested named function. But if you prefer an anonymous
function instead, never mind.

+    {
+      logo.removeEventListener("error", errorCallback, false);
+      // We are probably in Chrome/Opera/Safari, the image has a different path.
+      logo.src = "icons/detailed/abp-128.png";
+    };
+    logo.addEventListener("error", errorCallback, false);
+
     // Set up URLs
     getDocLink("donate", function(link)
     {
       E("donate").href = link;
     });
 
     getDocLink("contributors", function(link)
     {
       E("contributors").href = link;
     });
@@ skipping 206 matching lines @@
   {
     var button = E("toggle-" + feature);
     if (isEnabled)
       button.classList.remove("off");
     else
       button.classList.add("off");
   }
 
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();