Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5251080904507392: Got rid of classList.toggle() with second argument for compatibility with Safari (Closed)

Created:
Dec. 21, 2013, 6:59 p.m. by Sebastian Noack
Modified:
Dec. 23, 2013, 11:35 a.m.
Visibility:
Public.

Description

Safari doesn't support the second argument of classList.toggle(), which indicates whether the class should be added or removed, regardless of whether it currently exist. So we have to stick with classList.add() and classListe.remove().

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M popup.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
Dec. 21, 2013, 7:04 p.m. (2013-12-21 19:04:19 UTC) #1
Wladimir Palant
Dec. 22, 2013, 11:50 a.m. (2013-12-22 11:50:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld