Issue 1488 - Add pre-configurable preference to suppress first run page

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 80 matching lines @@
     // The "Hide placeholders" option has been removed from the UI in 1.8.8.1285
     // So we reset the option for users updating from older versions.
     if (previousVersion && Services.vc.compare(previousVersion, "1.8.8.1285") < 0)
       Prefs.hidePlaceholders = true;
 
     // Chrome on Linux does not fully support chrome.notifications until version 35
     // https://code.google.com/p/chromium/issues/detail?id=291485
     if (info.platform == "chromium" && "notifications" in chrome &&
         (navigator.platform.indexOf("Linux") == -1 ||
          Services.vc.compare(info.applicationVersion, "35") >= 0))
       initChromeNotifications();

[kzar, 2015/04/08 13:55:45]

Nit: IMHO should be a newline between initChromeNotifications() and
initAntiAdblockNotification().

[Sebastian Noack, 2015/04/08 15:11:20]

Well, this code belongs together. So I'd prefer to not have a newline here. But
anyway, those lines aren't touched by the latest patch.

[kzar, 2015/04/09 10:12:10]

No they don't, well not right together at least. There's a big comment above
explaining about the conditional logic and on first glance it's not obvious that
the "initAntiAdblockNotification()" call is made separately.

[Sebastian Noack, 2015/04/09 10:34:29]

Again, those lines aren't even remotely related to the change here.

[Wladimir Palant, 2015/04/09 18:32:42]

While I agree that a newline might improve code readability here, I also agree
that this isn't the right place to do it.

@kzar: Feel free to create a Noissue review for this change.

[Wladimir Palant, 2015/04/09 18:32:42]

While I agree that a newline might improve code readability here, I also agree
that this isn't the right place to do it.

@kzar: Feel free to create a Noissue review for this change.

     initAntiAdblockNotification();
 
     // Update browser actions and context menus when whitelisting might have
     // changed. That is now when initally loading the filters and later when
     // importing backups or saving filter changes.
     FilterNotifier.addListener(function(action)
     {
       if (action == "load" || action == "save")
         refreshIconAndContextMenuForAllPages();
     });
@@ skipping 123 matching lines @@
       if (subscription instanceof DownloadableSubscription && !subscription.lastDownload)
         Synchronizer.execute(subscription);
     }
   }
 
   if (!addSubscription && !addAcceptable)
     return;
 
   function notifyUser()
   {
-    ext.pages.open(ext.getURL("firstRun.html"));
+    if (!Prefs.suppress_first_run_page)
+      ext.pages.open(ext.getURL("firstRun.html"));
   }
 
   if (addSubscription)
   {
     // Load subscriptions data
     var request = new XMLHttpRequest();
     request.open("GET", "subscriptions.xml");
     request.addEventListener("load", function()
     {
       var node = Utils.chooseFilterSubscription(request.responseXML.getElementsByTagName("subscription"));
@@ skipping 349 matching lines @@
   page.sendMessage({type: "clickhide-deactivate"});
   refreshIconAndContextMenu(page);
 });
 
 setTimeout(function()
 {
   var notificationToShow = NotificationStorage.getNextToShow();
   if (notificationToShow)
     showNotification(notificationToShow);
 }, 3 * 60 * 1000);