Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: chrome/managed-storage-schema.json
Issue
5251132066627584
:
Issue 1488 - Add pre-configurable preference to suppress first run page (Closed)
Patch Set: Rebased and renamed onProgress() to checkLoaded()
Created April 8, 2015, 3:09 p.m.
Left:
Base
Patch Set 1:
Patch Set 2: Rebased and addressed comments
Patch Set 3: Rebased
Patch Set 4: Don't dispatch onChanged before loading is complete
Patch Set 5: Rebased and renamed onProgress() to checkLoaded()
Right:
Patch Set 1:
Patch Set 2: Rebased and addressed comments
Patch Set 3: Rebased
Patch Set 4: Don't dispatch onChanged before loading is complete
Patch Set 5: Rebased and renamed onProgress() to checkLoaded()
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
background.js
chrome/managed-storage-schema.json
lib/prefs.js
metadata.chrome
View unified diff
|
Download patch
« no previous file with comments
|
« background.js
('k') |
lib/prefs.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"type": "object",
3
"properties": {
4
"suppress_first_run_page": {
5
"type": "boolean"
6
}
7
}
8
}
OLD
NEW
« no previous file with comments
|
« background.js
('k') |
lib/prefs.js »
('j') |
no next file with comments »
Edit Message
Issue 5251132066627584: Issue 1488 - Add pre-configurable preference to suppress first run page (Closed)
Created March 19, 2015, 10:36 a.m. by Sebastian Noack
Modified April 20, 2015, 3:22 p.m.
Reviewers kzar, Wladimir Palant
Base URL:
Comments: 35
This is Rietveld