Issue 1488 - Add pre-configurable preference to suppress first run page

lib/prefs.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 79 matching lines @@
 }
 
 function init()
 {
   let prefs = Object.keys(defaults);
   prefs.forEach(addPreference);
 
   let localLoaded = false;
   let managedLoaded = false;
 
+  let checkLoaded = function()
+  {
+    if (!localLoaded || !managedLoaded)
+      return;
+
+    ext.storage.onChanged.addListener(function(changes)
+    {
+      for (let key in changes)
+      {
+        let pref = keyToPref(key);
+        if (pref && pref in defaults)
+        {
+          let change = changes[key];
+          if ("newValue" in change && change.newValue != defaults[pref])
+            overrides[pref] = change.newValue;
+          else
+            delete overrides[pref];
+
+          Prefs.onChanged._dispatch(pref);
+        }
+      }
+    });
+
+    Prefs.onLoaded._dispatch();
+  };
+
   // Migrate preferences for users updating from old versions.
   // TODO: Remove the migration code after a few releases.
   ext.storage.migratePrefs({
     map: function(key, value)
     {
       if (key in defaults)
       {
         if (key != "currentVersion")
         {
           try
@@ skipping 12 matching lines @@
       return null;
     },
 
     done: function()
     {
       ext.storage.get(prefs.map(prefToKey), function(items)
       {
         for (let key in items)
           overrides[keyToPref(key)] = items[key];
 
-        ext.storage.onChanged.addListener(function(changes)
-        {
-          for (let key in changes)
-          {
-            let pref = keyToPref(key);
-            if (pref && pref in defaults)
-            {
-              let change = changes[key];
-              if ("newValue" in change && change.newValue != defaults[pref])
-                overrides[pref] = change.newValue;
-              else
-                delete overrides[pref];
-
-              Prefs.onChanged._dispatch(pref);
-            }
-          }
-        });
-
         localLoaded = true;
-        if (localLoaded && managedLoaded)
-          Prefs.onLoaded._dispatch();
+        checkLoaded();
       });
     }
   });
 
   if (require("info").platform == "chromium" && "managed" in chrome.storage)
   {
     chrome.storage.managed.get(null, function(items)
     {
       for (let key in items)
         defaults[key] = items[key];
 
       managedLoaded = true;
-      if (localLoaded && managedLoaded)
-        Prefs.onLoaded._dispatch();
+      checkLoaded();
     });
   }
   else
   {
     managedLoaded = true;
+    checkLoaded();
   }
 }
 
 init();