Issue 2420 - Move notification show logic to core

lib/ui.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 401 matching lines @@
         for (let window of this.applicationWindows)
           this.updateStatusbarIcon(window);
       }
     }.bind(this));
     FilterNotifier.addListener(function(action)
     {
       if (/^(filter|subscription)\.(added|removed|disabled|updated)$/.test(action) || action == "load")
         this.updateState();
     }.bind(this));
 
-    Notification.addShowListener(function(notification)

[Wladimir Palant, 2015/06/08 11:33:15]

How about:

Notification.addShowListener(notification => 
{
  ...
});

You don't need to bind this then.

[Felix Dahlke, 2015/06/08 19:34:34]

Done.

+    Notification.addShowListener(notification =>
     {
       let window = this.currentWindow;
       if (!window)
         return;
 
       let button = window.document.getElementById("abp-toolbarbutton")
           || window.document.getElementById("abp-status");
       if (!button)
         return;
 
       this._showNotification(window, button, notification);
-    }.bind(this));
+    });
 
     // Add "anti-adblock messages" notification
     initAntiAdblockNotification();
 
     let documentCreationObserver = {
       observe: function(subject, topic, data)
       {
         if (!(subject instanceof Ci.nsIDOMWindow))
           return;
 
@@ skipping 1511 matching lines @@
   ["abp-command-contribute", "command", UI.openContributePage.bind(UI)],
   ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)]
 ];
 
 onShutdown.add(function()
 {
   for (let window of UI.applicationWindows)
     if (UI.isBottombarOpen(window))
       UI.toggleBottombar(window);
 });