Issue 2192 - Added notification opt-out mechanism (Core)

lib/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 173 matching lines @@
     }
 
     let notifications = localData.concat(remoteData);
     if (notifications.length === 0)
       return null;
 
     let {addonName, addonVersion, application, applicationVersion, platform, platformVersion} = require("info");
     let notificationToShow = null;
     for (let notification of notifications)
     {
-      if ((typeof notification.type === "undefined" || notification.type !== "critical")
-          && Prefs.notificationdata.shown.indexOf(notification.id) !== -1)
-        continue;
+      if (typeof notification.type === "undefined" || notification.type !== "critical")
+      {
+        if (Prefs.notificationdata.shown.indexOf(notification.id) !== -1
+            || Prefs.notifications_ignoredcategories.indexOf("*") !== -1)
+          continue;
+      }
 
       if (typeof url === "string" || notification.urlFilters instanceof Array)
       {
         if (typeof url === "string" && notification.urlFilters instanceof Array)
         {
           let matcher = new Matcher();
           for (let urlFilter of notification.urlFilters)
             matcher.add(Filter.fromText(urlFilter));
           if (!matcher.matchesAny(url, "DOCUMENT", url))
             continue;
@@ skipping 118 matching lines @@
    * @param {String} id notification ID
    * @param {Boolean} approved indicator whether notification has been approved or not
    */
   triggerQuestionListeners: function(id, approved)
   {
     if (!(id in listeners))
       return;
     let questionListeners = listeners[id];
     for (let listener of questionListeners)
       listener(approved);
+  },
+  
+  /**
+   * Toggles whether notifications of a specific category should be ignored
+   * @param {String} category notification category identifier
+   * @param {Boolean} [forceValue] force specified value
+   */
+  toggleIgnoreCategory: function(category, forceValue)
+  {
+    let categories = Prefs.notifications_ignoredcategories;
+    let index = categories.indexOf(category);
+    if (index == -1 && forceValue !== false)
+    {
+      categories.push(category);
+      Prefs.notifications_showui = true;
+    }
+    else if (index != -1 && forceValue !== true)
+      categories.splice(index, 1);
+
+    // HACK: JSON values aren't saved unless they are assigned a different object.
+    Prefs.notifications_ignoredcategories = JSON.parse(JSON.stringify(categories));
   }
 };
 Notification.init();