metadata.common - Issue 5279235799252992: Issue 491 - Validate custom filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 5279235799252992: Issue 491 - Validate custom filters (Closed)

Left Patch Set: Created Nov. 18, 2014, 3:57 p.m.

Right Patch Set: Improved test messages Created Nov. 21, 2014, 8:07 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 [general]	1 [general]

2 version = 1.8.7	2 version = 1.8.7

3 backgroundScripts = ext/common.js	3 backgroundScripts = ext/common.js

4 ext/background.js	4 ext/background.js

5 lib/compat.js	5 lib/compat.js

6 lib/info.js	6 lib/info.js

7 lib/io.js	7 lib/io.js

8 lib/adblockplus.js	8 lib/adblockplus.js

9 lib/punycode.js	9 lib/punycode.js

10 lib/publicSuffixList.js	10 lib/publicSuffixList.js

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 adblockplus/lib/subscriptionClasses.js	63 adblockplus/lib/subscriptionClasses.js

64 adblockplus/lib/filterStorage.js	64 adblockplus/lib/filterStorage.js

65 adblockplus/lib/elemHide.js	65 adblockplus/lib/elemHide.js

66 adblockplus/lib/matcher.js	66 adblockplus/lib/matcher.js

67 adblockplus/lib/filterListener.js	67 adblockplus/lib/filterListener.js

68 adblockplus/lib/synchronizer.js	68 adblockplus/lib/synchronizer.js

69 adblockplus/lib/notification.js	69 adblockplus/lib/notification.js

70 adblockplus/lib/antiadblockInit.js	70 adblockplus/lib/antiadblockInit.js

71 lib/stats.js	71 lib/stats.js

72 lib/whitelisting.js	72 lib/whitelisting.js

	73 lib/filterValidation.js

73 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/	74 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/

74 ext/common.js = ext/common.js chrome/ext/common.js	75 ext/common.js = ext/common.js chrome/ext/common.js

75 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand	76 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand

76	77

77 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js	78 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js

78 adblockplustests/chrome/content/tests/filterClasses.js	79 adblockplustests/chrome/content/tests/filterClasses.js

79 adblockplustests/chrome/content/tests/filterNotifier.js	80 adblockplustests/chrome/content/tests/filterNotifier.js

80 adblockplustests/chrome/content/tests/filterStorage.js	81 adblockplustests/chrome/content/tests/filterStorage.js

81 adblockplustests/chrome/content/tests/matcher.js	82 adblockplustests/chrome/content/tests/matcher.js

82 adblockplustests/chrome/content/tests/prefs.js	83 adblockplustests/chrome/content/tests/prefs.js

(...skipping 22 matching lines...) Expand all Loading...
105 addSubscription.label	106 addSubscription.label

106 addSubscriptionAdd.label	107 addSubscriptionAdd.label

107 addSubscriptionOther.label	108 addSubscriptionOther.label

108 acceptableAds2.label	109 acceptableAds2.label

109 viewList.label	110 viewList.label

110 readMore.label	111 readMore.label

111 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	112 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

112 title.label	113 title.label

113 adblockplus/chrome/locale/*/meta.properties = =name	114 adblockplus/chrome/locale/*/meta.properties = =name

114 adblockplus/chrome/locale//firstRun.properties = =	115 adblockplus/chrome/locale//firstRun.properties = =

LEFT	RIGHT