README.md - Issue 5288886037118976: Adblock Plus Crawler rewrite

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: README.md

Issue 5288886037118976: Adblock Plus Crawler rewrite (Closed)

Patch Set: Created April 24, 2015, 3:38 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 abpcrawler

	2 ==========

	3

	4 Firefox extension that loads a range of websites and records which
	Sebastian Noack 2015/04/27 14:55:50 Apparently its not only a Firefox extension but al Apparently its not only a Firefox extension but also a script running Firefox with that extension against a list of websites. Wladimir Palant 2015/05/07 00:04:59 Done. Show quoted text On 2015/04/27 14:55:50, Sebastian Noack wrote: > Apparently its not only a Firefox extension but also a script running Firefox > with that extension against a list of websites. Done.
	5 elements are filtered by [Adblock Plus](http://adblockplus.org).

	6

	7 Requirements

	8 ------------

	9

	10 * [Python 2.x](https://www.python.org)
	Sebastian Noack 2015/04/27 14:55:50 We actually require Python 2.7 specifically, as we We actually require Python 2.7 specifically, as we use argparse and collections.OrderedDict, and potentially other stuff introduced there. Wladimir Palant 2015/05/07 00:04:59 Done. Show quoted text On 2015/04/27 14:55:50, Sebastian Noack wrote: > We actually require Python 2.7 specifically, as we use argparse and > collections.OrderedDict, and potentially other stuff introduced there. Done.
	11 * [The Jinja2 module](http://jinja.pocoo.org/docs)

	12 * [mozrunner module](https://pypi.python.org/pypi/mozrunner)
	Sebastian Noack 2015/04/27 14:55:50 I think you should add Firefox to that list as wel I think you should add Firefox to that list as well. Wladimir Palant 2015/05/07 00:04:59 Done. Show quoted text On 2015/04/27 14:55:50, Sebastian Noack wrote: > I think you should add Firefox to that list as well. Done.
	13

	14 Running

	15 -------

	16

	17 Execute the following:

	18

	19 ./run.py -b /usr/bin/firefox urls.txt outputdir

	20

	21 This will run the specified Firefox binary to crawl the URLs from `urls.txt`

	22 (one URL per line). The resulting data and screenshots will be written to the

	23 `outputdir` directory. Firefox will close automatically once all URLs have been

	24 processed.

	25

	26 Optionally, you can provide the path to the Adblock Plus repository - Adblock
	saroyanm 2015/05/04 18:13:43 Maybe make sense to also add some small notes abou Maybe make sense to also add some small notes about -f flag so users will know they can customize the subscriptions ? Wladimir Palant 2015/05/07 00:04:59 Done. Show quoted text On 2015/05/04 18:13:43, saroyanm wrote: > Maybe make sense to also add some small notes about -f flag so users will know > they can customize the subscriptions ? Done.
	27 Plus will no longer be downloaded then.

	28

	29 License
	saroyanm 2015/05/04 18:13:43 Is there a purpose why we use MPL instead of GPL ? Is there a purpose why we use MPL instead of GPL ? Same questions goes to other JS files License headers. Wladimir Palant 2015/05/07 00:04:59 This extension was written before we switched to t Show quoted text On 2015/05/04 18:13:43, saroyanm wrote: > Is there a purpose why we use MPL instead of GPL ? Same questions goes to other > JS files License headers. This extension was written before we switched to the GPL, and I didn't bother relicensing it. Frankly, none of our Firefox extensions have been relicensed so far - with exception of Adblock Plus itself. saroyanm 2015/05/07 13:19:00 Got it, thanks. Show quoted text On 2015/05/07 00:04:59, Wladimir Palant wrote: > On 2015/05/04 18:13:43, saroyanm wrote: > > Is there a purpose why we use MPL instead of GPL ? Same questions goes to > other > > JS files License headers. > > This extension was written before we switched to the GPL, and I didn't bother > relicensing it. Frankly, none of our Firefox extensions have been relicensed so > far - with exception of Adblock Plus itself. Got it, thanks.
	30 -------

	31

	32 This Source Code is subject to the terms of the Mozilla Public License

	33 version 2.0 (the "License"). You can obtain a copy of the License at

	34 http://mozilla.org/MPL/2.0/.

OLD	NEW

« .hgignore ('K') | « .hgignore ('k') | build.py » ('j') | lib/commandLine.js » ('J')