metadata.gecko - Issue 5288886037118976: Adblock Plus Crawler rewrite

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.gecko

Issue 5288886037118976: Adblock Plus Crawler rewrite (Closed)

Left Patch Set: Created April 24, 2015, 3:38 p.m.

Right Patch Set: Addressed comments Created May 7, 2015, 12:04 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 id=abpcrawler@adblockplus.org	2 id=abpcrawler@adblockplus.org

3 basename=abpcrawler	3 basename=abpcrawler

4 version=0.1	4 version=0.2
saroyanm 2015/05/04 18:13:43 Version should be 0.2 at least. Version should be 0.2 at least. Wladimir Palant 2015/05/07 00:04:59 Done. Show quoted text On 2015/05/04 18:13:43, saroyanm wrote: > Version should be 0.2 at least. Done.
5 author=Felix H. Dahlke	5 author=Felix H. Dahlke

6	6

7 [compat]	7 [compat]

8 firefox=16.0/39.0	8 firefox=30.0/39.0
saroyanm 2015/05/04 18:13:43 The minimal version I think should be as minimum s The minimal version I think should be as minimum same as for Adblock Plus while this add-on is depends on ABP. Sebastian Noack 2015/05/04 20:39:01 IMO that line of arguing doesn't make sense. In th Show quoted text On 2015/05/04 18:13:43, saroyanm wrote: > The minimal version I think should be as minimum same as for Adblock Plus while > this add-on is depends on ABP. IMO that line of arguing doesn't make sense. In theory you could use abpcrawler also with older ABP versions on older FF versions. Also we're probably not going to update this file, every time we update the compatible versions for ABP. But well, it seems if we upgrade deferreds -> promises, we'll need Gecko 29 indeed. saroyanm 2015/05/05 09:36:39 agree. Show quoted text On 2015/05/04 20:39:01, Sebastian Noack wrote: > On 2015/05/04 18:13:43, saroyanm wrote: > > The minimal version I think should be as minimum same as for Adblock Plus > while > > this add-on is depends on ABP. > > IMO that line of arguing doesn't make sense. In theory you could use abpcrawler > also with older ABP versions on older FF versions. Also we're probably not going > to update this file, every time we update the compatible versions for ABP. > > But well, it seems if we upgrade deferreds -> promises, we'll need Gecko 29 > indeed. agree.
LEFT	RIGHT