Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: manifests/notificationserver.pp
Issue
5302563972841472
:
Merge filter and notification servers, have both tasks run on the same servers (Closed)
Patch Set: Stopped misusing is_default parameter
Created Jan. 30, 2014, 2:10 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Stopped misusing is_default parameter
Right:
Patch Set 1: None
Patch Set 2: Stopped misusing is_default parameter
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
manifests/filterserver.pp
manifests/monitoringserver.pp
manifests/nodes.pp
manifests/notificationserver.pp
modules/filterserver/manifests/init.pp
modules/filterserver/templates/easylist-downloads.adblockplus.org.erb
modules/notificationserver/manifests/init.pp
modules/notificationserver/templates/notification.adblockplus.org.erb
modules/statsmaster/files/sitescripts.ini
View unified diff
|
Download patch
« manifests/filterserver.pp
('K') |
« manifests/nodes.pp
('k') |
modules/filterserver/manifests/init.pp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
node 'notification1', 'notification2' {
2
include base, notificationserver
3
4
class {'nagios::client':
5
server_address => 'monitoring.adblockplus.org'
6
}
7
8
class {'statsclient': }
9
}
OLD
NEW
« manifests/filterserver.pp
('K') |
« manifests/nodes.pp
('k') |
modules/filterserver/manifests/init.pp »
('j') |
no next file with comments »
Edit Message
Issue 5302563972841472: Merge filter and notification servers, have both tasks run on the same servers (Closed)
Created Jan. 30, 2014, 11:49 a.m. by Wladimir Palant
Modified Jan. 31, 2014, 1:03 p.m.
Reviewers: Felix Dahlke
Base URL:
Comments: 8
This is Rietveld