sitescripts/stats/bin/logprocessor.py - Issue 5315116274810880: Issue 1811 - logprocessor crashes if unable to process one log file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: sitescripts/stats/bin/logprocessor.py

Issue 5315116274810880: Issue 1811 - logprocessor crashes if unable to process one log file (Closed)

Patch Set: Created Jan. 14, 2015, 11:06 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: sitescripts/stats/bin/logprocessor.py

===================================================================

--- a/sitescripts/stats/bin/logprocessor.py

+++ b/sitescripts/stats/bin/logprocessor.py

@@ -518,17 +518,17 @@ def parse_source(factor, lock, (mirror_n

try:

save_stats(server_type, data, factor)

finally:

lock.release()

return log_file, ignored

except:

print >>sys.stderr, "Unable to process log file '%s'" % log_file

traceback.print_exc()

- return None, None, None, None

+ return None, None

def parse_sources(sources, factor=1, verbose=False):

pool = multiprocessing.Pool()

lock = multiprocessing.Manager().Lock()

callback = functools.partial(parse_source, factor, lock)

try:

for log_file, ignored in pool.imap_unordered(callback, sources, chunksize=1):

if verbose and ignored:

« no previous file with comments | « no previous file | no next file » | no next file with comments »